Rename Mage_Core_Block_Abstract::getHelper #25

Closed
stalniy opened this Issue Jun 10, 2012 · 1 comment

2 participants

@stalniy

Mage_Core_Block_Abstract::getHelper should be renamed because it's not intuitively that this method returns a singleton block instance and by other hand Mage_Core_Block_Abstract::helper returns a singleton instance of helper.

@magento-team

We have revised this method and found, that it is a legacy one with no usage in Magento code. So we have removed it at all and fixed the PHPDoc of Mage_Core_Block_Abstract::helper() method.

You can expect the changes to appear in the next publication.

Thank you for the notice regarding these methods.

@magento-team magento-team added a commit that referenced this issue Jun 21, 2012
@magento-team magento-team Update as of 6/20/2012
* Implemented locale translation inheritance
* Implemented new format for exporting customer data
* Added initial Javascript code for globalization and localization
* Added initial Javascript unit tests
* Implemented file signature for urls of static files - better CDN support
* Implemented optional tracking of changes in view files fallback - cached by default, tracked in developer mode
* Introduced `@magentoDbIsolation` annotation in integration tests - isolates DB modifications made by tests
* Started refactoring of Visual Design Editor Javascript architecture
* Github requests:
  * [#25](#25) Removed unused `Mage_Core_Block_Abstract::getHelper()` method
* Fixed:
  * "$_FILES array is empty" messages in exception log upon installation
  * Long attribute table aliases, that were producing errors at DB with lower identifier limitation than MySQL
  * Watermark opacity function did not work with ImageMagick
  * `Magento_Test_TestCase_ControllerAbstract::assertRedirect` was used in a wrong way
  * Inability to reorder a downloadable product
  * ACL tables aliases interference with other table aliases
* Several tests are made incomplete temporary, appropriate bugs to be fixed in the nearest future
0c3e67e
@mmansoorebay mmansoorebay pushed a commit that referenced this issue Jan 30, 2014
@zerkella zerkella In scope of MAGETWO-1536 (GitHub Tickets Processing 36) fixed helper …
…instantiation in Block Abstract

- it is a response to issue #25 (#25)
- removed getHelper(), because it is not used anywhere
- fixed PhpDoc for helper() method
b157ec4
This was referenced Jan 16, 2015
This was referenced Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment