Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image resizing and watermarking do no take into consideration the relative dimensions of the watermark and watermarked image. #25514

Closed
janssentwh opened this issue Nov 7, 2019 · 5 comments
Assignees
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@janssentwh
Copy link

janssentwh commented Nov 7, 2019

Introduction

In Magento 2.3.3 it is possible to upload watermarks. By doing so your product images are watermarked indeed. But, when uploading product images of different sizes, the watermark's size is altered relative to the product image. These images below better illustrate my point:
Small base product image:
image

Large base product image:
image

Reproduced in Luma 2.3-develop:
image

Preconditions (*)

The issue is reproducible in Magento 2.3.3

Steps to reproduce (*)

  1. Create two products.
  2. Give one product an image of size 400x400.
  3. Give the second product an image of size 1200x1200.
  4. Add a watermark with width 200px.
  5. Refresh image cache.
  6. Generate cached images by visiting the product's product detail page.
  7. Notice that the watermarks are not of equal size.

Expected result (*)

  1. I expect the watermark to take into consideration the relative size of the image, so that the watermark always is the same width and height regardless of the product image.

Actual result (*)

  1. The smaller product image gets a larger watermark, the larger product image gets a smaller watermark.
@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2019

Hi @janssentwh. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@janssentwh do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 7, 2019
@janssentwh
Copy link
Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @janssentwh. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @janssentwh, here is your Magento instance.
Admin access: https://i-25514-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost assigned Krielkip Nov 8, 2019
@VladimirZaets VladimirZaets added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 14, 2019
@VladimirZaets
Copy link
Contributor

Hi @janssentwh. Thank you for your report.
The issue has been fixed in #25528 by @Krielkip in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

magento-engcom-team added a commit that referenced this issue Nov 14, 2019
…25528

 - Merge Pull Request #25528 from Krielkip/magento2:bug/25514
 - Merged commits:
   1. 85415ef
   2. 2263d2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

4 participants