2.3.4 Invoice always sent (if exist) when order placed.

[ilnytskyi]

Preconditions (*)

related to attempt to fix
#13466

commit
5ccd367

1. h3. Steps to reproduce (*)

2. Place order with a payment method that instantly generates an invoice
3. The module/code that generated an invoice now is responsible for checking it's state and send to customer
4. but here 896ae3b#diff-5e96777dde905631ad1729751f5cc83fR72 magento checks if invoice exist and send it to customer
5. If so, pleas give the possibility to disable this in sales*model_service_quote_submit*success without code modifying or changing \Magento\Quote\Observer\SubmitObserver::execute or its dependencies

Expected result (*)

1. Invoice Sending is managed by modules that created this invoice and should be configurable
2. Invoice is not sent the same time the order placed
3. or this feature is disabled and can be configured

Actual result (*)

1. Invoice is always sent if exists 896ae3b#diff-5e96777dde905631ad1729751f5cc83fR7
2. The original intention to fix Invoice Sales Email not send #13466 if so the PayPal module is responsible for sending its invoice NOT MAGENTO QUOTE MODULE

[m2-assistant]

Hi @ilnytskyi. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ilnytskyi do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[ilnytskyi]

@magento-engcom-team @StasKozar @viktym

[magento-engcom-team]

✅ Confirmed by @sdzhepa
Thank you for verifying the issue. Based on the provided information internal tickets MC-33893 were created

Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[zakdma]

@magento i am working on it

[zakdma]

We discussed this task and made decision we'll create separate observer for invoice emails so isolate invoice email sending from order email sending. Developer can disable the observer following the documentation instructions https://devdocs.magento.com/guides/v2.4/extension-dev-guide/events-and-observers.html
Also invoice email sending will depend on sales_email/invoice/enabled configuration (Yes by default)
So functionality will work as before but there is possibility to change it behaviour as developer need.

[magento-engcom-team]

Hi @ilnytskyi, @ilnytskyi, @zakdma.

Thank you for your report and collaboration!

The related internal Jira ticket MC-33893 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.