Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate layout handle update #265

Closed
1 of 5 tasks
MichaelThessel opened this issue Aug 6, 2020 · 3 comments · Fixed by #263
Closed
1 of 5 tasks

Duplicate layout handle update #265

MichaelThessel opened this issue Aug 6, 2020 · 3 comments · Fixed by #263
Labels
Component: 2FA Issues and Pull Requests related to Two Factor Authentication should be marked with this label
Projects

Comments

@MichaelThessel
Copy link

Preconditions (*)

  1. 2.4

Steps to reproduce (*)

  1. Look at: vendor/magento/module-two-factor-auth/view/adminhtml/layout/tfa_tfa_requestconfig.xml

This contains the <update handle="tfa_screen" /> layout update instruction twice.

Expected result (*)

  1. Single layout update instruction

Actual result (*)

  1. Duplicate layout update instruction

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2020

Hi @MichaelThessel. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sdzhepa
Copy link
Contributor

sdzhepa commented Aug 11, 2020

Transferred to security-package repo

@sdzhepa sdzhepa transferred this issue from magento/magento2 Aug 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2020

Hi @MichaelThessel. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@m2-community-project m2-community-project bot added this to Ready for Grooming in Backlog Aug 11, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Backlog Aug 11, 2020
@sdzhepa sdzhepa added the Component: 2FA Issues and Pull Requests related to Two Factor Authentication should be marked with this label label Aug 11, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Backlog Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: 2FA Issues and Pull Requests related to Two Factor Authentication should be marked with this label
Projects
Backlog
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants