New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/magento module:uninstall never completes #3544

Closed
andrew-smart opened this Issue Feb 25, 2016 · 18 comments

Comments

Projects
None yet
@andrew-smart
Copy link
Contributor

andrew-smart commented Feb 25, 2016

I've tested this on a fresh 2.0.2 installation.

I installed a sample module of mine using composer and then afterwards ran bin/magento module:uninstall Smartie_SampleModule

This is the output;

Enabling maintenance mode
You are about to remove a module(s) that might have database data. Remove the database data manually after uninstalling, if desired.
Removing Smartie_SampleModule from module registry in database
Removing Smartie_SampleModule from module list in deployment configuration
Removing code from Magento codebase:

This is where it gets stuck. The module is removed from the composer.json file but it never gets removed from the vendor dir.

@mazhalai

This comment has been minimized.

Copy link
Contributor

mazhalai commented Feb 25, 2016

How long did you wait @andrew-smart?

@andrew-smart

This comment has been minimized.

Copy link
Contributor

andrew-smart commented Mar 6, 2016

I ran another test and so far i have waited 30 minutes without any further output. Not sure how long i should wait but that seems quite excessive :)

@mazhalai

This comment has been minimized.

Copy link
Contributor

mazhalai commented Mar 28, 2016

@andrew-smart sorry for the delay, can you please give us more details about your env, like OS, and PHP version, so that we can try to reproduce this.

@mazhalai mazhalai added the PS label Mar 28, 2016

@paulerickson

This comment has been minimized.

Copy link

paulerickson commented Apr 26, 2016

@andrew-smart : have you added any repositories to composer.json? I've seen this too, and my theory is that module:uninstall triggers composer update in another thread (or otherwise hides the output). Thus when composer prompts for credentials to our custom repo, it blocks, waiting on username and password from standard in, which magento never provides. An untested theory at this point; I don't really know what it does under the covers.

@mazhalai

This comment has been minimized.

Copy link
Contributor

mazhalai commented May 9, 2016

@andrew-smart closing this as non-responsive.

@mazhalai mazhalai closed this May 9, 2016

@andrew-smart

This comment has been minimized.

Copy link
Contributor

andrew-smart commented May 12, 2016

@mazhalai My Apologies. I have not been getting updates from this ticket.
I run natively on mac osx with brew installed php 5.6.20 and mysql 5.6.27 with native apache.

@paulerickson Yes this is a custom repo. I built it to test the new uninstall scripts within modules. Your theory is quite interesting but not sure how I can test it.

@Dayssam

This comment has been minimized.

Copy link

Dayssam commented May 18, 2016

Hi everyone

@paulerickson As you said , your theory is wright, it demand in background to enter your GitHub credentials to access private repos

This is what i get when i run the uninstall command line

Command "remove" failed: <warning>emizentech/shopbybrand is not required in your composer.json and has not been removed</warning>
Loading composer repositories with package information
Cloning failed using an ssh key for authentication, enter your GitHub credentials to access private repos
A token will be created and stored in "/var/www/magento2/var/composer_home/auth.json", your password will never be stored
To revoke access to this token you can visit https://github.com/settings/applications
Username: Password:
Bad credentials.
You can also manually create a personal token at https://github.com/settings/applications
Add it using "composer config github-oauth.github.com <token>"
Username: Password:
Bad credentials.
You can also manually create a personal token at https://github.com/settings/applications
Add it using "composer config github-oauth.github.com <token>"
Username: Password:
Bad credentials.
You can also manually create a personal token at https://github.com/settings/applications
Add it using "composer config github-oauth.github.com <token>"
Username: Password:
Bad credentials.
You can also manually create a personal token at https://github.com/settings/applications
Add it using "composer config github-oauth.github.com <token>"
Username: Password:
Bad credentials.
You can also manually create a personal token at https://github.com/settings/applications
Add it using "composer config github-oauth.github.com <token>"

  [RuntimeException]
  Invalid GitHub credentials 5 times in a row, aborting.

remove [--dev] [--no-progress] [--no-update] [--update-no-dev] [--update-with-dependencies] [--ignore-platform-reqs] [packages1] ... [packagesN]

Please disable maintenance mode after you resolved above issues
@Dayssam

This comment has been minimized.

Copy link

Dayssam commented May 18, 2016

The solution is to run : composer update in an other console

@gabriellucius

This comment has been minimized.

Copy link

gabriellucius commented Aug 3, 2016

I have the same problem here, I call the bin/magento module:uninstall module_name and the command prompt stops in "Removing code from Magento codebase" too.

Any sollutions or fixes discovered?

Obs: All the data to be uninstalled were uninstaled

@hostep

This comment has been minimized.

Copy link
Collaborator

hostep commented Aug 3, 2016

Linking this thread to an issue I discovered last week, it might be the same problem: #5797

@twistedatrocity

This comment has been minimized.

Copy link

twistedatrocity commented Feb 25, 2017

This should be reopened as it persists in 2.1.4. The workaround is Control-C on the command when it hangs at removing code, then run composer update, however this is not a solution. The module:uninstall should work properly otherwise why even have it?

So sick of issues like this in magento, I have a notepad filled with workarounds on things that should just work. Test your f'ing code better before releasing it. I'm starting to think CE is just a public beta for their money grab EE. About to recommend a different platform to all my clients. Fed up.

@akoslovasz

This comment has been minimized.

Copy link

akoslovasz commented Mar 17, 2017

I've done some debugging, and it seems the problem is with the Magento repository. When calling bin/magento module uninstall Vendor_Module, it calls composer remove in the background, and the method addRepository in Composer\DependencyResolver\Pool somehow gets into an infinite loop. Temporarily removing the Magento repository from composer.json fixes the problem. Anyway, a proper final solution would be useful.

@vasilii-b

This comment has been minimized.

Copy link
Contributor

vasilii-b commented May 30, 2017

@Dayssam , yes, that solution works if you canceled the module:uninstall command previously.

@nickbartlett

This comment has been minimized.

Copy link

nickbartlett commented Jun 1, 2017

@mazhalai can this issue be re-opened please? We have the same issue as @andrew-smart initially described. Uninstalling a module will remove the entry from composer.json, and run the database uninstall scripts, but when it attempts to remove the code it hangs with message "removing code from Magento codebase:" . One thing to note is our module has its own composer.json file where it requires and installed another codebase.

As I see in vendor/magento/framework/Composer/Remove.php, Magento tries to run 'remove' composer command.
runComposerCommand() method can be found here: vendor/magento/composer/src/MagentoComposerApplication.php
it gets stuck on line $exitCode = $this->consoleApplication->run($input, $this->consoleOutput);

FYI manually executing the command "composer remove my/module" works successfully.

@andidhouse

This comment has been minimized.

Copy link

andidhouse commented Aug 15, 2017

I this fixed in 2.1.7 or 2.1.8 @magento-team ?

@joaoasrosa

This comment has been minimized.

Copy link

joaoasrosa commented Sep 5, 2017

@andidhouse I just try it on 2.1.8 and is not fixed.

@LucScu

This comment has been minimized.

Copy link

LucScu commented Sep 12, 2017

If this issue is not yet fixed, why is it signed as closed?

@Brigel

This comment has been minimized.

Copy link

Brigel commented Sep 14, 2017

Composer stoped in load data from repo.magento.com

My auth.json was not correct. This decision helped me

config http-basic.repo.magento.com <public_key> <private_key>
https://magento.stackexchange.com/questions/90983/how-to-use-the-new-repo-magento-com

magento-engcom-team pushed a commit that referenced this issue Dec 18, 2018

Merge pull request #3544 from magento-panda/MAGETWO-97161
Fixed issues:
  - MAGETWO-97161 Static tests failed on mainline (2.3-develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment