Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini/sidebar shopping cart limit/count not implemented #4750

Closed
jzahedieh opened this issue May 27, 2016 · 7 comments

Comments

@jzahedieh
Copy link

@jzahedieh jzahedieh commented May 27, 2016

Steps to reproduce

  1. Install Magento from version 2.0.6 (enterprise) branch with sample data.
  2. Set store configuration Maximum Display Recently Added Item(s) to `2
    (Located under Sales > Checkout > Shopping Cart Sidebar)
  3. Clear caches
  4. Add 3+ separate items to basket.
  5. Assert limited to two in mini cart / checkout sidebar

Expected result

  1. Assert 2 items are displayed in mini cart and checkout sidebar

Actual result

No limit implemented (from what I can tell)

[Screenshot - Sidebar]
sidebar

[Screenshot - Minicart]
minicart

Code Search

I have also had a nosy around the code,

checkout/sidebar/display has been assigned to a constant in
vendor/magento/module-checkout/Block/Cart/Sidebar.php:18

But I can't find any reference for the configuration option checkout/sidebar/count, has this been implemented?

@jzahedieh jzahedieh changed the title Mini/sidebar shipping cart limit/count not implemented Mini/sidebar shopping cart limit/count not implemented May 27, 2016
@jzahedieh

This comment has been minimized.

Copy link
Author

@jzahedieh jzahedieh commented May 31, 2016

I have upgrade to 2.0.7 EE and the issue persists

@MomotenkoNatalia MomotenkoNatalia added the CS label Jun 1, 2016
@ishakhsuvarov ishakhsuvarov self-assigned this Jun 1, 2016
@ishakhsuvarov

This comment has been minimized.

Copy link
Contributor

@ishakhsuvarov ishakhsuvarov commented Jun 1, 2016

@jzahedieh Thank you for reporting this issue. We have created an internal ticket MAGETWO-53793 to investigate and fix the problem.

@jzahedieh

This comment has been minimized.

Copy link
Author

@jzahedieh jzahedieh commented Jul 5, 2016

I see a few commits in relation to the fix were included in 2.1, could you please confirm that the issue is fixed because I can still add infinite products to both my minibag and checkout side bar, if so I will update with more formal bug report.

Thanks.

@elenleonova

This comment has been minimized.

Copy link

@elenleonova elenleonova commented Jul 15, 2016

Hi, the issue is still present in 2.1, and we plan to have it fixed in one of the following patches. We will update the ticket once it becomes available. However, the issue have been fixed for 2.2, thus closing the ticket.

@elenleonova

This comment has been minimized.

Copy link

@elenleonova elenleonova commented Aug 10, 2016

The fix has been released as a part of 2.0.9.

@elenleonova

This comment has been minimized.

Copy link

@elenleonova elenleonova commented Aug 30, 2016

The issue has been released in 2.1.1.

@magestyle

This comment has been minimized.

Copy link

@magestyle magestyle commented Oct 12, 2016

Thank you for raising this issue @jzahedieh.

I can confirm this issue is fixed on 2.1.1

screen shot 2016-10-12 at 14 34 37

screen shot 2016-10-12 at 14 36 20

magento-engcom-team pushed a commit that referenced this issue Sep 11, 2019
[honey] MC-19746: The shipping address contains `null` values when there's no shipping address set on a cart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.