New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Custom Options get recreated on every save #5931

Closed
mktudock opened this Issue Aug 2, 2016 · 29 comments

Comments

Projects
@mktudock

mktudock commented Aug 2, 2016

Possibly related to #5885

Preconditions

  1. Have Magento 2.1. (with PHP 7)
  2. Install the sample data and create a new store view
  3. Go to any (configurable) product and create a custom option as a dropdown with some options (for global)

Steps to reproduce

  1. Open the product again
  2. Save

Expected result

  1. The custom option ID in the database should be the same as before

Actual result

  1. The custom option gets recreated with a new ID. Same for all other tables (titles, types etc.)

This is a very critical bug for us, since it prevents any customer from completing the checkout with certain payment methods and it propably leads to the issues in #5885.

@mktudock

This comment has been minimized.

Show comment
Hide comment
@mktudock

mktudock Aug 2, 2016

Also if anyone would have a temporary solution for us, even if it prevents custom options from being saved, I'd be very happy, this is urgent!

mktudock commented Aug 2, 2016

Also if anyone would have a temporary solution for us, even if it prevents custom options from being saved, I'd be very happy, this is urgent!

@mktudock

This comment has been minimized.

Show comment
Hide comment
@mktudock

mktudock Aug 2, 2016

The commit that caused this behaviour is
0f00630

mktudock commented Aug 2, 2016

The commit that caused this behaviour is
0f00630

@mktudock

This comment has been minimized.

Show comment
Hide comment
@mktudock

mktudock Aug 3, 2016

I also want to point out that this means that all products in quotes with the custom options attached have their custom options removed on save, since it's no longer the same id! That basically renders the product useless, since important custom options are missing in the final order.

mktudock commented Aug 3, 2016

I also want to point out that this means that all products in quotes with the custom options attached have their custom options removed on save, since it's no longer the same id! That basically renders the product useless, since important custom options are missing in the final order.

@veloraven

This comment has been minimized.

Show comment
Hide comment
@veloraven

veloraven Aug 8, 2016

Contributor

@mktudock thank you for your report.

We already have internal ticket for this issue: MAGETWO-56411
Created for GitHub issue #5612
I have linked it to this issue as well.

Contributor

veloraven commented Aug 8, 2016

@mktudock thank you for your report.

We already have internal ticket for this issue: MAGETWO-56411
Created for GitHub issue #5612
I have linked it to this issue as well.

@philipvandebriel

This comment has been minimized.

Show comment
Hide comment
@philipvandebriel

philipvandebriel Oct 10, 2016

I have same problem.

I have same problem.

@vincentwinkel

This comment has been minimized.

Show comment
Hide comment
@vincentwinkel

vincentwinkel Oct 19, 2016

I discovered this behaviour several months ago but I thought it was normal.
So, same problem too, and it's very critical...

I discovered this behaviour several months ago but I thought it was normal.
So, same problem too, and it's very critical...

@manfrinm

This comment has been minimized.

Show comment
Hide comment
@manfrinm

manfrinm Nov 3, 2016

Contributor

@veloraven Do you have any update on this?

Contributor

manfrinm commented Nov 3, 2016

@veloraven Do you have any update on this?

@JosephWein

This comment has been minimized.

Show comment
Hide comment
@JosephWein

JosephWein Nov 23, 2016

@veloraven The issue(s) with custom options are stopping our migration to M2 in its tracks. When will they be assigned? Thanks

@veloraven The issue(s) with custom options are stopping our migration to M2 in its tracks. When will they be assigned? Thanks

@tomasinchoo

This comment has been minimized.

Show comment
Hide comment
@tomasinchoo

tomasinchoo Nov 25, 2016

Member

Does anyone @magento knows how urgent this situation is?

Member

tomasinchoo commented Nov 25, 2016

Does anyone @magento knows how urgent this situation is?

@Choufourax

This comment has been minimized.

Show comment
Hide comment
@Choufourax

Choufourax Dec 26, 2016

The bug still here in version 2.1.3.
So disappointing...........

The bug still here in version 2.1.3.
So disappointing...........

@kaushalsutharhs

This comment has been minimized.

Show comment
Hide comment
@kaushalsutharhs

kaushalsutharhs Mar 2, 2017

Does anyone have any temporary fix to resolve this issue?

Does anyone have any temporary fix to resolve this issue?

@manfrinm

This comment has been minimized.

Show comment
Hide comment
@manfrinm

manfrinm Mar 2, 2017

Contributor

Hello, I've created this patch CustomOptions Patch that solve this issue and the Cart option missing issue #5612
The patch can be applied on CE 2.1.5 or 2.1.4 and on EE 2.1.5 or 2.1.4 but I've tested this patch only for Magento EE 2.1.5.
Hopes is helpful

Contributor

manfrinm commented Mar 2, 2017

Hello, I've created this patch CustomOptions Patch that solve this issue and the Cart option missing issue #5612
The patch can be applied on CE 2.1.5 or 2.1.4 and on EE 2.1.5 or 2.1.4 but I've tested this patch only for Magento EE 2.1.5.
Hopes is helpful

@kaushalsutharhs

This comment has been minimized.

Show comment
Hide comment
@kaushalsutharhs

kaushalsutharhs Mar 8, 2017

@manfrinm : I'm getting error

 Applying patches for magento/module-catalog
    https://raw.githubusercontent.com/Hevelop/magento2-patches/master/Patch-Magento_Catalog-M2.1.5-MAGETWO-56410-MAGETWO-56411-github-issues-5931-5612.patch (Fix: https://github.com/magento/magento2/issues/5612)
   Could not apply patch! Skipping.

@manfrinm : I'm getting error

 Applying patches for magento/module-catalog
    https://raw.githubusercontent.com/Hevelop/magento2-patches/master/Patch-Magento_Catalog-M2.1.5-MAGETWO-56410-MAGETWO-56411-github-issues-5931-5612.patch (Fix: https://github.com/magento/magento2/issues/5612)
   Could not apply patch! Skipping.
@sheldmandu

This comment has been minimized.

Show comment
Hide comment
@sheldmandu

sheldmandu Mar 27, 2017

We are also experiencing this issue. In addition to shopping cart options it also affects Reorder functionality. This is also a problem not just for custom options on simple products but also for bundle options, which should probably be raised as a separate issue.

We are also experiencing this issue. In addition to shopping cart options it also affects Reorder functionality. This is also a problem not just for custom options on simple products but also for bundle options, which should probably be raised as a separate issue.

@sheldmandu

This comment has been minimized.

Show comment
Hide comment
@sheldmandu

sheldmandu Apr 10, 2017

Is there any indication when this issue would be resolved? This is quite a major issue for anyone looking to use Simple Products with Custom Options as it renders them practically unusable.

Is there any indication when this issue would be resolved? This is quite a major issue for anyone looking to use Simple Products with Custom Options as it renders them practically unusable.

@Choufourax

This comment has been minimized.

Show comment
Hide comment
@Choufourax

Choufourax Apr 10, 2017

Yes this is crazy such an issue is not fixed after monthes.
I had to write a special .htaccess to forbid my client to edit some products in the backend........

Yes this is crazy such an issue is not fixed after monthes.
I had to write a special .htaccess to forbid my client to edit some products in the backend........

@scottsb

This comment has been minimized.

Show comment
Hide comment
@scottsb

scottsb Apr 14, 2017

Contributor

If it helps others, I have produced a reduced version of @manfrinm's patch, as the original included some good but unnecessary changes that were causing patch application errors.

Contributor

scottsb commented Apr 14, 2017

If it helps others, I have produced a reduced version of @manfrinm's patch, as the original included some good but unnecessary changes that were causing patch application errors.

@tomasinchoo

This comment has been minimized.

Show comment
Hide comment
@tomasinchoo

tomasinchoo Apr 14, 2017

Member

@scottsb Thanks. @veloraven Is anybody at Magento aware how urgent this situation is? It looks like community is expected to handle it of its own..

Member

tomasinchoo commented Apr 14, 2017

@scottsb Thanks. @veloraven Is anybody at Magento aware how urgent this situation is? It looks like community is expected to handle it of its own..

@sheldmandu

This comment has been minimized.

Show comment
Hide comment
@sheldmandu

sheldmandu Jun 6, 2017

Hi @scottsb I tried the patch and it seems to have some issues when you delete an option value (that's not the last one). What happens it also seems to delete option values from other options too. Would be great if someone could fix.

Hi @scottsb I tried the patch and it seems to have some issues when you delete an option value (that's not the last one). What happens it also seems to delete option values from other options too. Would be great if someone could fix.

@magento-team magento-team moved this from TODO to Done in branch [2.3-develop] Jul 19, 2017

@piavgh

This comment has been minimized.

Show comment
Hide comment
@piavgh

piavgh Aug 9, 2017

@magento-team, @veloraven : I'm really appreciated that the fix is finally "moved from TODO to Done in branch [develop]"
When are you guys going to release this fix?
Thank you.

piavgh commented Aug 9, 2017

@magento-team, @veloraven : I'm really appreciated that the fix is finally "moved from TODO to Done in branch [develop]"
When are you guys going to release this fix?
Thank you.

@Taral-Patoliya

This comment has been minimized.

Show comment
Hide comment
@Taral-Patoliya

Taral-Patoliya Aug 11, 2017

@magento-team , @veloraven : would you care to at-least prepare a patch and provide us as a quick fix until it is released officially with the newer version? this is something very critical and we can not move ahead with our project.

@magento-team , @veloraven : would you care to at-least prepare a patch and provide us as a quick fix until it is released officially with the newer version? this is something very critical and we can not move ahead with our project.

@Taral-Patoliya

This comment has been minimized.

Show comment
Hide comment
@Taral-Patoliya

Taral-Patoliya Aug 11, 2017

@manfrinm , @scottsb, i tried applying your patches the options are not being replaced now but in case we are using multiple custom options, if we remove one value form a custom options, all the values from other custom options are getting removed also.

@manfrinm , @scottsb, i tried applying your patches the options are not being replaced now but in case we are using multiple custom options, if we remove one value form a custom options, all the values from other custom options are getting removed also.

@thlassche

This comment has been minimized.

Show comment
Hide comment
@thlassche

thlassche Aug 28, 2017

@sheldmandu / @Taral-Patoliya Did you manage to find a solution for the delete other options problem?

@sheldmandu / @Taral-Patoliya Did you manage to find a solution for the delete other options problem?

@sheldmandu

This comment has been minimized.

Show comment
Hide comment
@sheldmandu

sheldmandu Sep 20, 2017

@magento-engcom-team Is this issue fixed in 2.2? It's marked as Done in develop. It's the same underlying problem as that for bundles described in #9546

@magento-engcom-team Is this issue fixed in 2.2? It's marked as Done in develop. It's the same underlying problem as that for bundles described in #9546

@magento-engcom-team

This comment has been minimized.

Show comment
Hide comment
@magento-engcom-team

magento-engcom-team Sep 20, 2017

Contributor

@mktudock, thank you for your report.
The issue is already fixed in 2.2.0

Contributor

magento-engcom-team commented Sep 20, 2017

@mktudock, thank you for your report.
The issue is already fixed in 2.2.0

@sheldmandu

This comment has been minimized.

Show comment
Hide comment
@sheldmandu

sheldmandu Oct 13, 2017

@magento-engcom-team Any chance of this being backported to 2.1 as it's quite a major issue that stops reorders working? Perhaps you could point me to a commit in which this issue was resolved so I can review what would be involved in backporting myself?

@magento-engcom-team Any chance of this being backported to 2.1 as it's quite a major issue that stops reorders working? Perhaps you could point me to a commit in which this issue was resolved so I can review what would be involved in backporting myself?

@vekariyajyoti173

This comment has been minimized.

Show comment
Hide comment
@vekariyajyoti173

vekariyajyoti173 Jan 25, 2018

hello,

I have facing same issue as #5612.

Can you please help me how to resolve?

I have use magento 2.1.7.

I also apply patches given by you but it creates same option again and displays two times in frontend.

vekariyajyoti173 commented Jan 25, 2018

hello,

I have facing same issue as #5612.

Can you please help me how to resolve?

I have use magento 2.1.7.

I also apply patches given by you but it creates same option again and displays two times in frontend.

@vekariyajyoti173

This comment has been minimized.

Show comment
Hide comment
@vekariyajyoti173

vekariyajyoti173 Jan 25, 2018

If Possible then give patches for it.......

If Possible then give patches for it.......

@Ctucker9233

This comment has been minimized.

Show comment
Hide comment
@Ctucker9233

Ctucker9233 Mar 6, 2018

@magento-engcom-team Can you please provide links to the commits that fix this?

@magento-engcom-team Can you please provide links to the commits that fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment