Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Html validator #619

Closed
Den4ik opened this Issue Jul 20, 2014 · 12 comments

Comments

Projects

Done in branch [develop]

9 participants

Den4ik commented Jul 20, 2014

Good solution integrate HTML Purifier into Magento. It help validate html code for unclosed tags. Sometimes in static blocks and pages html code not clear.

Contributor

kandy commented Jul 20, 2014

HtmlPurifier library has incompatible license, so cannot be included in repository

@verklov verklov added the suggestion label Aug 5, 2014

Contributor

verklov commented Aug 5, 2014

@Den4ik, thank you for your suggestion! I have forwarded it to the Product Manager responsible for the area. We will get back to you once we have an update.

tkacheva commented Aug 5, 2014

@Den4ik Thank you for suggestion! HtmlPurifier doesn't support html 5. Could you help me to understand issues you want to solve with html 5 validation?

Den4ik commented Aug 5, 2014

Sure. I faced with a variety of situations where we have unclosed html tags
in static blocks or pages. Or sometimes we have wrong html in product
descriptions. I think html validation for it is good idea

@Den4ik Closing tags is optional in html 5, if I'm not mistaken? Generally, I agree that validation is great idea but I can't think about any solution that will help with html 5. Do you?

Html validator is a good idea, our editors copy and paste from external
editors(word e.g.) and the special format sometimes break the whole page

On Thu, Aug 14, 2014 at 2:24 PM, tkacheva notifications@github.com wrote:

@Den4ik https://github.com/Den4ik Closing tags is optional in html 5,
if I'm not mistaken? Generally, I agree that validation is great idea but I
can't think about any solution that will help with html 5. Do you?


Reply to this email directly or view it on GitHub
#619 (comment).

Den4ik commented Aug 22, 2014

@tkacheva Sorry for delay. Yes, HTMLPurifier doesn't support html5. Now I'm working with my custom purifier, that support html5 for one of my projects.
ll let you know when I've finished library.

Contributor

vpelipenko commented Jan 29, 2015

Internal ticket: MAGETWO-27039

@Den4ik Just wonder if you have any updates?

Contributor

kandy commented Mar 17, 2015

https://github.com/Masterminds/html5-php - look like applicable html5 validation library

@magento-team magento-team pushed a commit that referenced this issue Sep 18, 2015

@viktym viktym Merge pull request #619 from magento-mpi/MAGETWO-43005
[MPI] Sprint 71
444e252

hi,
I have problems with unclosed html tags, thousands of html contents needs to be validate. Other static blocks doesnt show up properly. I need someone advise me something.
thanks

@magento-team magento-team pushed a commit that referenced this issue May 14, 2016

@slavvka slavvka Merge pull request #619 from magento-firedrakes/MAGETWO-52746
[Firedrakes] P0-P1 Bug fixes
b5900bc

@vkorotun vkorotun removed the CS label Aug 4, 2016

Contributor

piotrekkaminski commented Aug 30, 2016

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

@mmansoorebay mmansoorebay pushed a commit that referenced this issue Nov 28, 2016

@rganin rganin Merge pull request #619 from magento-troll/pull-second
MAGETWO-60205: Prices are incorrect in SF for configurable product with tier-prices
d491a45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment