Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Datepicker/calendar control does not use the store locale #6350

Closed
heldchen opened this issue Aug 26, 2016 · 19 comments

Comments

@heldchen
Copy link
Contributor

commented Aug 26, 2016

the frontend datepicker control (for example for the DOB field) is not localized: month names, day names and week start date are all using en_US.

Preconditions

  1. Magento 2.1.0 CE
  2. a non-en_US language pack is installed, which contains the translated month and weekday names, assuming de_DE for this issue
  3. frontend store is set to use this language/locale

Steps to reproduce

  1. Admin > Settings > Configuration > Customer > Customer Configuration > "Show Date of Birth: Require"
  2. Admin > Settings > Configuration > General > Locale Options > "First Day of Week: Monday"
  3. clear cache / rebuild static assets if needed
  4. in the frontend, edit your account and use the datepicker of the DoB control

Expected result

  1. the month names in the dropdown are translated
  2. the weekday names are translated
  3. the week starts with monday

Actual result

  1. the month names are in english
  2. the weekday names are in english
  3. the week starts with sunday

@heldchen heldchen changed the title Datepicker/calendar control does not use the store locale Frontend: Datepicker/calendar control does not use the store locale Aug 26, 2016

@sevos1984

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2016

Thanks for reporting, intrnal ticket MAGETWO-57733

@lfritsche

This comment has been minimized.

Copy link

commented Nov 15, 2016

@sevos1984
is there any update about this issue?
Our customers are not happy with the unknown date-formatting and I would need a solution quiet soon.
Thank you!

@robinkanters

This comment has been minimized.

Copy link

commented Feb 12, 2017

@sevos1984 any progress? it's been almost half a year now

@tmelnichuk

This comment has been minimized.

Copy link

commented Feb 23, 2017

@lfritsche @robinkanters Seem's like adding block Magento\Framework\View\Element\Html\Calendar to the layout of required page resolves this problem (Magento 2.1.2 CE)

So I've added app/design/frontend/<Vendor>/<theme>/Magento_Customer/layout/customer_account_edit.xml with next content:

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <body>
        <referenceContainer name="content">
            <block class="Magento\Framework\View\Element\Html\Calendar" name="html_calendar" as="html_calendar" template="Magento_Theme::js/calendar.phtml" before="-"/>
        </referenceContainer>
    </body>
</page>
@joachimVT

This comment has been minimized.

Copy link

commented Sep 26, 2017

Working on this ticket.

@joachimVT joachimVT referenced this issue Sep 26, 2017
0 of 4 tasks complete
@magento-team

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2017

Internal ticket to track issue progress: MAGETWO-80096

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2017

@heldchen, thank you for your report.
We've created internal ticket(s) MAGETWO-57733 to track progress on the issue.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

Hi @heldchen the issue has been fixed in #11067 by @joachimVT . The fix will be available in 2.2.1

@digvijay2017

This comment has been minimized.

Copy link

commented Nov 10, 2017

This issue still exists in Magento 2.2.1 . I have checked Today.

magento2-1-1

@peterjaap

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2017

@okorshenko please re-open this issue. I can confirm this issue still exists on 2.2.1.

@okorshenko

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2018

Hi @heldchen. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1353 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@peterjaap

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2018

As far as I can see this is the only relevant commit; 72e9e07

And that is already in (at least) 2.2.3. But it still does not work.

@nntoan

This comment has been minimized.

Copy link
Contributor

commented May 1, 2018

I can confirm that it still does not work in 2.2.3. Should we reopen the issue?

@vishalnyati

This comment has been minimized.

Copy link

commented May 7, 2018

Calendar translation is not working for me yet.. I started with 2.1.7 and updates every releases now i have upgraded it to 2.2.3 but still issues is same.( almost an year) Calendar is not translated in any other locale other than English. Is there any chance it will fix anytime soon in future ..

@peterjaap

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2018

@navinbhudiya

This comment has been minimized.

Copy link

commented Jun 20, 2018

@okorshenko I can confirm that it still does not work in 2.2.3. Should we reopen the issue?

@navinbhudiya

This comment has been minimized.

Copy link

commented Jul 12, 2018

@magento-engcom-team any update? any quick solution?

@peterjaap

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2018

Not fixed in 2.2.6.

@Anarcociclista

This comment has been minimized.

Copy link

commented May 9, 2019

Waiting for the fix in the core, we made a module that temporarily fix this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.