Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine widget rule #7274

Closed
Pigau opened this issue Nov 2, 2016 · 3 comments
Closed

Combine widget rule #7274

Pigau opened this issue Nov 2, 2016 · 3 comments
Labels
bug report Component: Catalog Component: Cms Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@Pigau
Copy link

Pigau commented Nov 2, 2016

Hi,
I have some problem to use combine rule in product list widget.
It seems that the method Magento\CatalogWidget\Model\Rule\Condition\Combine::collectValidatedAttributes is not correct and try to call addToCollection without checking the rule type

Preconditions

  1. Magento 2.1.1

Steps to reproduce

  1. Add a new widget 'Catalog Product List' on a cms page
  2. Add a combine rule condition (ex: product_id=1 or price > 0)
  3. Go to the page on front

Expected result

  1. See product list widget

Actual result

  1. Error : Invalide method Magento\CatalogWidget\Model\Rule\Condition\Combine::addToCollection

Is anyone having the same problem ?
Thank you for your help
@olysenko olysenko self-assigned this Nov 7, 2016
@olysenko
Copy link

olysenko commented Nov 7, 2016

Hi, Thank you for your report. Internal issue was created MAGETWO-60602

@Pigau Pigau added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed in progress labels Nov 7, 2016
mmansoor-magento pushed a commit that referenced this issue Nov 23, 2016
@irenelagno
MAGETWO-60602: [Github] Combine widget rule #7274
8102ba4
@SerhiyShkolyarenko
Copy link
Contributor

MAGETWO-60602 is delivered to the develop branch. We are closing the issue.

@SerhiyShkolyarenko SerhiyShkolyarenko self-assigned this Nov 23, 2016
@Ctucker9233
Copy link

@magento-engcom-team Will there be a backport for 2.1?

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Component: Catalog Component: Cms Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@veloraven @olysenko @SerhiyShkolyarenko @Pigau @Ctucker9233 @magento-engcom-team