Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine widget rule #7274

Closed
Pigau opened this issue Nov 2, 2016 · 3 comments
Closed

Combine widget rule #7274

Pigau opened this issue Nov 2, 2016 · 3 comments

Comments

@Pigau
Copy link

@Pigau Pigau commented Nov 2, 2016

Hi,
I have some problem to use combine rule in product list widget.
It seems that the method Magento\CatalogWidget\Model\Rule\Condition\Combine::collectValidatedAttributes is not correct and try to call addToCollection without checking the rule type

Preconditions

  1. Magento 2.1.1

Steps to reproduce

  1. Add a new widget 'Catalog Product List' on a cms page
  2. Add a combine rule condition (ex: product_id=1 or price > 0)
  3. Go to the page on front

Expected result

  1. See product list widget

Actual result

  1. Error : Invalide method Magento\CatalogWidget\Model\Rule\Condition\Combine::addToCollection

Is anyone having the same problem ?
Thank you for your help

@olysenko
Copy link

@olysenko olysenko commented Nov 7, 2016

Hi, Thank you for your report. Internal issue was created MAGETWO-60602

@SerhiyShkolyarenko
Copy link
Contributor

@SerhiyShkolyarenko SerhiyShkolyarenko commented Nov 23, 2016

MAGETWO-60602 is delivered to the develop branch. We are closing the issue.

@Ctucker9233
Copy link

@Ctucker9233 Ctucker9233 commented Nov 11, 2017

@magento-engcom-team Will there be a backport for 2.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.