Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ImportExport module produces PHP strict notices #80

FiveDigital opened this Issue Sep 14, 2012 · 3 comments


5 participants

The ImportExport module especially the model Mage_ImportExport_Model_Import_Entity_Product is accessing non existing array keys without checking them first. This leads to a system.log full of Notice: Undefined index:

Notice: Undefined index: sku  in /app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php on line 1717
Notice: Undefined index: _type  in /app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php on line 1240
Notice: Undefined index: _type  in /app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php on line 1241

barbazul commented Sep 14, 2012

Also, there is a typo in the name of one of the media* attributes: _media_lable instead of _media_label in Mage_ImportExport_Model_Import_Entity_Product which has led me to a lot of confusion in the past.


magento-team commented Oct 12, 2012

Thanks for mentioning these code issues. We have quick-fixed them and covered with tests.

magento-team added a commit that referenced this issue Nov 12, 2012
* Framework changes
  * Added dependency injection of framework capability
    * Adopted Zend\Di component of Zend Framework 2 library
    * Implemented object manager in Magento application
    * Refactored multiple base classes to dependency injection principle (dependencies are declared in constructor)
  * Themes/View
    * Implemented storing themes registry in database, basic CRUD of themes, automatic registration of themes in database from file system out of the box
    * Renamed `Mage_Core_Model_Layout_Update` into `Mage_Core_Model_Layout_Merge`, the former becomes an entity domain model. Similar changes with `Mage_Core_Model_Resource_Layout` -> `Mage_Core_Model_Resource_Layout_Update`, `Mage_Core_Model_Layout_Data` -> `Mage_Core_Model_Layout_Update`
* Performance tests
  * Improved indexers running script `dev/shell/indexer.php` to return appropriate exit code upon success/failure
  * Implemented running the same performance scenario file with different parameters
  * Slightly refactored framework class `Magento_Performance_Testsuite_Optimizer` for better visibility of algorithm
* Visual design editor
  * Added ability to remove elements in editor UI
  * Revised history of changes VDE toolbar and algorithm of "compacting" operations (moving, removing elements) as a layout update XML
  * Added selection of themes to VDE launcher page
* Refactored JavaScript of some UI elements to jQuery:
  * "Simple" and "configurable" product view pages
  * "Create Account" page
  * "Shopping Cart" page
  * Newsletter subscription
* Tax management UX improvements
  * Split Basic and Advanced Settings for Tax Rule Management UI
  * Moved the Import/Export functionality to Tax Rate page
  * Moved Tax menu to System from Sales
* Implemented the editable multiselect JavaScript component
* Added mentioning sitemap in `robots.txt` after generation
* Removed creation of DB backup in integration testing framework
* Fixed logic of order of loading ACL resources in backend
* Fixed JavaScript error during installation when one of files in `pub/media` is not writable
* Fixed structure of legacy test fixtures that allowed ambiguous keys in declaration
* Fixed inability to restore admin password when CAPTCHA is enabled
* Various minor UX fixes (labels, buttons, redirects, etc...)
* GitHub requests:
  * [#59](#59) -- implemented handling of unexpected situations in admin/dashboard/tunnel action
  * [#66](#66)
    * refactored ImageMagick adapter unit test to avoid system operation
    * simplified unit testing framework -- removed unused classes, simplified handling logic of directory `dev/tests/unit/tmp` and removed it from VCS
  * [#73](#73), [#74](#74) -- fixes in docblock tags
  * [#75](#75), [#96](#96) -- fixed translation module contexts in a few places
  * [#80](#80) -- fixed some runtime errors in import/export module
  * [#81](#81) -- removed usage of "remove" directive in places where it is overridden by setting root template anyway
  * [#87](#87) -- changed paths of files to include from relative into absolute in `dev/shell/indexer.php` and `log.php`
  * [#88](#88) -- provided comments for values that can be configured in `app/etc/local.xml` file
  * [#90](#90) -- slightly optimized logic of implementation of loading configurable product attributes

magento-team pushed a commit that referenced this issue Feb 6, 2015

Merge pull request #80 from magento-ogre/develop-new
[Ogres] Sprint 22 Contribution

magento-team pushed a commit that referenced this issue Mar 23, 2016

Merge pull request #80 from AnastasiaBuniakEPAM/JS-375
Js 375: ProductVideo works incorect when Gallery updates

@magento-engcom-team magento-engcom-team moved this from TODO to Done in branch [2.3-develop] Sep 12, 2017

sandermangel pushed a commit to sandermangel/magento2 that referenced this issue Oct 15, 2017

art6495 commented Nov 8, 2017

I want to remove sku during product import using csv in magento, Can you please check it??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment