Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Checkout Step and Shipping Step are Highlighted and Combined upon Checkout page load #8410

Closed
natebatty opened this issue Feb 3, 2017 · 6 comments
Assignees
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@natebatty
Copy link

Preconditions

  1. Magento 2.1
  2. PHP 7

Steps to reproduce

  1. Create a custom checkout step. Set the step to appear first.
  2. Start the checkout process
  3. Both my custom step and the shipping step are displaying and highlighted
  4. Upon using the next buttons the steps show up in their own section

Expected result

  1. Shipping step should be hidden since it is now step 2

Actual result

  1. Both my custom step and the shipping step are displaying and highlighted
@psyklopz
Copy link

I can confirm the same behavior. I also created a custom checkout step (sortOrder: 0 in the xml, sortOrder:5 in js) so that it would appear before the shipping step. When you first visit the checkout, it will show both steps highlighted on the top bar. Additionally, the content for both steps will both be shown until you click the next button. It will run the validator for my custom step, then move to the shipping step. From here, I can move back to my custom step and it will display only my custom step. Not surprisingly, I can also visit "http://localhost/checkout/#mycustomstep", and it will properly display my step on it's own.

Attached is a zip of my module, which may be helpful in debugging this issue.
CustomCheckoutStepBug.zip

@psyklopz
Copy link

There may be a workaround described in this issue report, but I'm still trying to understand what is said... #8875

@psyklopz
Copy link

Confirmed it's also an issue with:

Preconditions

Magento version 2.1.6
PHP version 5.6.30
Used browser: Google Chrome, Mozilla Firefox

@magento-engcom-team magento-engcom-team added G1 Passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team self-assigned this Nov 7, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Nov 7, 2017
@magento-engcom-team
Copy link
Contributor

@natebatty, thank you for your report.
We've created internal ticket(s) MAGETWO-83363 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@magento-engcom-team magento-engcom-team removed their assignment Nov 7, 2017
@RomaKis RomaKis self-assigned this Dec 7, 2017
@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 11, 2017
@okorshenko
Copy link
Contributor

Hi @natebatty
The issue has been fixed and delivered in 2.2-develop branch. Will be available with upcoming patch release.

@ryangerber1990
Copy link

This wasn't fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants