New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Shopping Cart Gift Options without page reload #9206

Closed
ishakhsuvarov opened this Issue Apr 11, 2017 · 2 comments

Comments

Projects
5 participants
@ishakhsuvarov
Contributor

ishakhsuvarov commented Apr 11, 2017

Current implementation of the Gift Options for Order and Item in Shopping Cart requires page reload to add and remove a Gift Option. This behavior is confusing to the user, as API request is sent in the background and provides no feedback until page reloads. Additionally this has effect on performance, since cart page is not stored in cache.

Acceptance Criteria

  • Gift Options for Item and Order are assigned with an Web API request, without page reload.
  • Customer can immediately observe the result of the action.
  • Blocks on the Shopping Cart Page, which may be affected by this action (e. g. Totals) are updated in asynchronous manner as well.

@ishakhsuvarov ishakhsuvarov added this to TODO in Up For Grabs Apr 11, 2017

@okorshenko okorshenko added this to Verified in MagentoLive India 2017 Apr 21, 2017

@ishakhsuvarov ishakhsuvarov removed this from Verified in MagentoLive India 2017 May 12, 2017

StevenGuapaBV added a commit to BasBlanken/magento2 that referenced this issue May 13, 2017

StevenGuapaBV added a commit to BasBlanken/magento2 that referenced this issue May 13, 2017

StevenGuapaBV added a commit to BasBlanken/magento2 that referenced this issue May 13, 2017

StevenGuapaBV added a commit to BasBlanken/magento2 that referenced this issue May 13, 2017

StevenGuapaBV added a commit to BasBlanken/magento2 that referenced this issue May 15, 2017

StevenGuapaBV added a commit to BasBlanken/magento2 that referenced this issue May 15, 2017

@StevenGuapaBV

This comment has been minimized.

Show comment
Hide comment
@StevenGuapaBV

StevenGuapaBV May 15, 2017

Collaborator

Created pull request for fixing this issue.
Page refresh is now replaced by a XHR request and labels are shown more clearly.

Fixed along with @JesseGuapa, kudos for him

#9626

Collaborator

StevenGuapaBV commented May 15, 2017

Created pull request for fixing this issue.
Page refresh is now replaced by a XHR request and labels are shown more clearly.

Fixed along with @JesseGuapa, kudos for him

#9626

@okorshenko okorshenko moved this from TODO to In Progress in Up For Grabs May 15, 2017

@ishakhsuvarov ishakhsuvarov moved this from In Progress to PR Created in Up For Grabs May 20, 2017

@okorshenko okorshenko added this to Pull Request In Progress in Community Dashboard May 28, 2017

@okorshenko okorshenko moved this from PR Created to TODO in Up For Grabs Jun 24, 2017

@okorshenko okorshenko moved this from Pull Request In Progress to TODO in Community Dashboard Jun 24, 2017

@magento-engcom-team

This comment has been minimized.

Show comment
Hide comment
@magento-engcom-team

magento-engcom-team Oct 6, 2017

Contributor

Closing the issue due to inactivity

Contributor

magento-engcom-team commented Oct 6, 2017

Closing the issue due to inactivity

@okorshenko okorshenko moved this from TODO to Done in Community Dashboard Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment