Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.1.6 shrunk my base images #9385

Closed
pioneerathletics opened this issue Apr 24, 2017 · 16 comments
Closed

Magento 2.1.6 shrunk my base images #9385

pioneerathletics opened this issue Apr 24, 2017 · 16 comments
Labels
bug report Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@pioneerathletics
Copy link

Preconditions

  1. Magento 2.1.6
  2. PHP 7.0.15

Steps to reproduce

  1. Update from Magento 2.1.4 to Magento 2.1.6 via the Web Setup Wizard
  2. Update was successful
  3. Looked at products and base image was much smaller than previously
  4. Could not change the base image size back to normal within the gallery using etc>view.xml. Image size would increase but so would gallery size rendering the image out of alignment

Expected result

  1. Update shouldn't cause the base images to be smaller, because view.xml was not changed (screenshot 1)
    screenshot-1

Actual result

  1. All base images are smaller (screenshot 2)
    screenshot-2

  2. Size of gallery stage went from 672x437 to 437x437 (screenshot 3)
    screenshot-3

@tigerx7
Copy link

tigerx7 commented Apr 25, 2017

I ran into this issue myself recently... seems that Magento is now setting <frame></frame> to default to true now when this didn't used to be the case; at least from the version we updated from.

<frame></frame> adds white space around your image to force the exact width/height of the setting in view.xml while preserving aspect ratio. To not have Magento do this, you now have to include <frame>false</frame> within that image definition in view.xml

But there's a catch... there's a bug in Magento that reads <frame>false</frame> as a string when typecasting to bool, so it keeps it as true. Here's a more detailed discussion on that and how to best patch it: #4622

After updating the view,xml and cleaning cache, you'll have to manually resize all your images with bin/magento catalog:images:resize Fair warning, it does take awhile depending on how many images you have.

@choukalos
Copy link

Tracking internally as MAGETWO-67805

@korostii
Copy link
Contributor

@tigerx7, I think it's worth mentioning here that discussion under #4622 also suggests to include <frame>0</frame> as a workaround until that bug is fixed.

@aaronallen8455
Copy link

I also have this issue after updating to 2.1.6.
In addition to shrunken product images, the gallery thumbnails are zoomed in so as to vertically fill the entire thumbnail space and are blurred as a result.
I tried adding <frame>0</frame> to all the product images in view.xml and ran the cache flush and image resize command but this doesn't seem to change anything with the product image or the thumbnails.

@tigerx7
Copy link

tigerx7 commented Apr 28, 2017

@aaronallen8455 did you apply commit 1bbcff4? Unfortunately 0 on its own is also being read as true since "0" is typecasted directly from a string thus becomes true. Also make sure to flush the cache after the image resize command.

@jfrontain
Copy link

@pioneerathletics et al, please check out the Technical Bulletin we've just posted about this issue with 2.1.6. We hope it helps -- if not, send information my way, and we'll try again.

http://devdocs.magento.com/guides/v2.1/release-notes/tech_bull_216-imageresize.html

@aaronallen8455
Copy link

I finally got rid of the white border by going into cache management and using the 'Flush Catalog Images Cache' button before running the resize command. Just running the cache:clean command isn't enough.

@keithbentrup
Copy link
Contributor

keithbentrup commented May 4, 2017

I posted this on #9395, but it may help here, too.

@ps3z
Copy link

ps3z commented May 15, 2017

sites are looking ugly with it, we are waiting new release for fix the issue as soon as possible

@yumicom
Copy link

yumicom commented May 16, 2017

I have the same issue with bad resizing of additional small images on product page after upgrading to 2.1.6.
In my etc>view.xml :
image id="product_page_image_small" type="thumbnail"
width>50</width
height>50</height
frame>0</frame
/image
Image size is good only if width and height = 90.

@versdivers
Copy link

I have done everything by now. I tried to make chances to my view.xml. I tried to adjust the helper. I applied the patch and everything. Just nothing works! This is really really horrible. If you have a fix ready just implement it and release it under 2.1.7...

@margo-nik
Copy link

@jfrontain Agrees with the comment above. After applying the patch and editing view.xml still does not work.

@luismaldonadov
Copy link

luismaldonadov commented May 26, 2017

I've just donwloaded the patch but i dont know how to apply it. I've tried giving it permissions to execute and with bash, but it seems that is not a bash script. Can anyone give instructions?.

Thank you.

EDIT

I've just realized is a git patch. I've run this command in the root folder

git apply --stat MAGETWO-67805-2017-05-17-03-04-03.patch

I dont know if its correct.

@heyepic
Copy link

heyepic commented May 28, 2017

I've tried everything and cannot fix this - and worse, I'm going live with a site soon. Is there a general ETA of when this will be addressed? Seems like a big issue.

@mzeis
Copy link
Contributor

mzeis commented May 31, 2017

Magento just released 2.1.7 with a "reversion of the changes to image resizing that we introduced in 2.1.6": http://devdocs.magento.com/guides/v2.1/release-notes/ReleaseNotes2.1.7CE.html

Can you please check if the problem is gone in 2.1.7? Thanks!

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 12, 2017
@veloraven
Copy link
Contributor

@pioneerathletics I'm closing this issue as it was fixed in Magento 2.1.7.
If you still experience this problem please create new GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests