Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for url_rewrite on page delete via api #10569

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Fix for url_rewrite on page delete via api #10569

merged 2 commits into from
Aug 17, 2017

Commits on Aug 17, 2017

  1. Fix for url_rewrite on page delete via api 

    For develop see PR magento#10568

Problem: when deleting a cms page via api the url_rewrites aren't deleted

Steps to reproduce:
- add cms page via api
- delete cms page via api
- add new cms page with same identifier via api
- ERROR: Could not save the page, URL key already exists

Solution: moved di.xml from etc/adminhtml to etc/ folder in CmsUrlRewrite module
Event trigger to delete url rewrites is located in di.xml
    An Van den Bosch committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    ffd33ff View commit details
    Browse the repository at this point in the history

  2. magento#10569: Fix for url_rewrite on page delete via api 

     - api-functional test added
    @ishakhsuvarov
    ishakhsuvarov committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    f26b05d View commit details
    Browse the repository at this point in the history