Add Role column to admin user grid#10891
Conversation
| )->join( | ||
| ['detail_role' => $this->getTable('authorization_role')], | ||
| 'user_role.parent_id = detail_role.role_id', | ||
| ['role_name'] |
There was a problem hiding this comment.
This will affect every user collection instantiated, isn't it?
Something like https://magento.stackexchange.com/a/124204, a separate collection just for grid, looks like a better option. Not sure if there is to way do it in more declarative way.
Just my 2 cents, before proceeding please wait for somebody to actually confirm such feature fits well into core.
There was a problem hiding this comment.
Yes the JOINs will happen on every collection load. This was based on the sales rule grid
Not sure what the concern would be. The performance cost should be negligible.
There was a problem hiding this comment.
I searched for the usages of this Collection, it is not used in any performance-critical flows. Join should be fine here.
There was a problem hiding this comment.
@vrann glad to know, thanks! Hope you checked EE/B2B codebases as well.
Is it correct that such approach with _initSelect is up-to-date? Like, there is no declarative way to declare join for the grid etc.
|
please merge with the latest from |
|
@mpchadwick ^^ |
|
@vrann Should be merge develop back in tonight hopefully. |
|
@vrann I've merged |
|
@vrann Just pushed an update to fix visibility on _initSelect. Viewing Locked Users page in admin was resulting in 500 error. Noticed that while looking at the Travis results. |
|
@mpchadwick thank you, I also fixed that internally. Another issue needed to resolve was with the b2b version crashing when filtered by user_id column: now it is ambiguous which table user_id should come from. |
|
@mpchadwick thank you, the feature is successfully accepted. It is not indicated as merge because we did the same commit. |
5 participants
Description
Adds a column to the admin user grid to show the users role
This can be useful for example to see all the users with "admin" privileges on a store with many users. Without this, you need to click into each manually
See: #9557
Contribution checklist