Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Down changes from PR#10919 #11160

Merged
merged 1 commit into from Oct 4, 2017

Conversation

@strell
Copy link
Contributor

commented Sep 30, 2017

From db79dbf Mon Sep 17 00:00:00 2001
From: freakphp mail@freak.io
Date: Sun, 17 Sep 2017 12:52:00 +0200
Subject: [PATCH 1/2] #10803 update OrderService to return correct bool value for cancel method

From d4cddf7 Mon Sep 17 00:00:00 2001
From: Ievgen Shakhsuvarov ishakhsuvarov@users.noreply.github.com
Date: Mon, 18 Sep 2017 12:22:00 +0200
Subject: [PATCH 2/2] #10919: update OrderService to return correct bool value

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Related Pull Requests

#10919

@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2017

CLA assistant check
All committers have signed the CLA.

Ported Down changes from PR#10919
From db79dbf Mon Sep 17 00:00:00 2001
From: freakphp <mail@freak.io>
Date: Sun, 17 Sep 2017 12:52:00 +0200
Subject: [PATCH 1/2] #10803 update OrderService to return correct bool value for cancel method

From d4cddf7 Mon Sep 17 00:00:00 2001
From: Ievgen Shakhsuvarov <ishakhsuvarov@users.noreply.github.com>
Date: Mon, 18 Sep 2017 12:22:00 +0200
Subject: [PATCH 2/2] #10919: update OrderService to return correct bool value

@strell strell force-pushed the strell:2.2-develop branch from 92c441c to 2a9255c Sep 30, 2017

@orlangur orlangur self-assigned this Sep 30, 2017

@orlangur orlangur added this to the September 2017 milestone Sep 30, 2017

@orlangur

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

@strell please force push this PR branch without last commit (not related to initial backport).

@strell strell force-pushed the strell:2.2-develop branch from f972da8 to 2a9255c Oct 2, 2017

@strell

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2017

@orlangur Done, force pushed.

@okorshenko okorshenko merged commit 2a9255c into magento:2.2-develop Oct 4, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.