Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable secret key validation on admin noroute to fix redirect loop #11229

Merged
merged 1 commit into from Oct 4, 2017

Conversation

@convenient
Copy link
Contributor

commented Oct 4, 2017

Similar to 2f422ad but using the framework.

Fixes issue #10611 for the 2.2-develop branch.

Doesn't address the route cause, but only fixes the symptom as per #10921 (comment)

If preferred I can rebase this branch to do a cherry-pick of 2f422ad, but I figured it better to use the framework to achieve this feature.

Steps to reproduce

  1. Create a user role with no resources assigned to it.
  2. Create an admin user with that role.
  3. Log in with that user.
  4. Should see an "Access denied" screen rather than a redirect loop.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
Disable secret key validation on admin noroute to fix redirect loop
Similar to 2f422ad but using the framework.

Fixes issue #10611 for the `2.2-develop` branch.

Doesn't address the route cause, but only fixes the symptom as per #10921 (comment)
@convenient

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2017

Runtime:       PHP 7.1.9
Configuration: /home/travis/build/magento/magento2/dev/tests/functional/phpunit.xml
...............
The job exceeded the maximum time limit for jobs, and has been terminated.

@okorshenko Any chance we can re-trigger the travis build to see if this is some intermittent issue?

@okorshenko

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2017

Done

@okorshenko okorshenko merged commit ded7e67 into magento:2.2-develop Oct 4, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codacy/pr Good work! A positive pull request.
Details
licence/cla Contributor License Agreement is signed.
Details
okorshenko added a commit that referenced this pull request Oct 4, 2017

@convenient convenient deleted the convenient:fix-issue-10611 branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.