Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10856: Sync billing with shipping address on Admin Order Page #11385

Merged
merged 4 commits into from Oct 24, 2017

Conversation

@joni-jones
Copy link
Contributor

commented Oct 11, 2017

Fixed Issues

  1. #10856: Sync billing with shipping address on Admin Reorder and Admin Customer Create Order page does not work for Existing address selected

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
Sync billing with shipping address on Admin Order Page
 - Set customer address ID only if the address was selected in dropdown
 - Removed "old" billing address from quote if customer address doesn't specified
@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko self-assigned this Oct 11, 2017

@okorshenko okorshenko added this to the October 2017 milestone Oct 11, 2017

Sync billing with shipping address on Admin Order Page
 - Added validation for empty applied taxes to avoid exceptions during json decoding
@joni-jones

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2017

@magento-team, I see needs update label, any questions about this PR?

Sync billing with shipping address on Admin Order Page
 - Fixed skipped 'Same as billing' checkbox

@okorshenko okorshenko merged commit b1a0181 into magento:2.2-develop Oct 24, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
okorshenko added a commit that referenced this pull request Oct 24, 2017

@joni-jones joni-jones deleted the joni-jones:G#10856 branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.