Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #10810 Migrates Apache Access Syntax to 2.4 on Apache >= 2.4 #11459

Merged
merged 2 commits into from Nov 10, 2017

Conversation

@jonashrem
Copy link
Contributor

commented Oct 14, 2017

Migrates Apache Access Syntax to 2.4 on Apache >= 2.4

Description

In all .htaccess Files, the Apache 2.2 Auth Blocks like


            order allow,deny
            deny from all

have been replaced with this block:

        <IfVersion < 2.4>
            order allow,deny
            deny from all
        </IfVersion>
        <IfVersion >= 2.4>
            Require all denied
        </IfVersion>

Fixed Issues (if relevant)

  1. #10810: Add support of apache2.4 commands in htaccess

Manual testing scenarios

  1. Install on Apache 2.4 and check whether all file access rules work as intended
  2. Install on Apache 2.2 and check whether all file access rules work as intended

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
close #10810
Migrates Apache Access Syntax to 2.4 on Apaxhe >= 2.4
@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2017

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017

@okorshenko okorshenko merged commit 00937b1 into magento:2.2-develop Nov 10, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
okorshenko added a commit that referenced this pull request Nov 10, 2017
okorshenko pushed a commit that referenced this pull request Nov 12, 2017
MAGETWO-82294: migrated pull request #11459 to 2.3 develop #11466
 - Merge Pull Request #11466 from jonashrem/magento2:10810-2.3
 - Merged commits:
   1. a6f517d
okorshenko added a commit that referenced this pull request Nov 12, 2017
Merge pull request #1706 from magento-engcom/develop-prs
Public Pull Requests

#12155 update button.phtml overcomplicated translation phrase. Magento 2.3 by @ChuckyK
#11680 #8022: Uncaught Error: Call to a member function addItem() on array in app/code/Magento/Sales/Model/Order/Shipment.php by @RomaKis
#11466 migrated pull request #11459 to 2.3 develop by @jonashrem

Fixed Public Issues

#8022 Uncaught Error: Call to a member function addItem() on array in app/code/Magento/Sales/Model/Order/Shipment.php
#10810 Add support of apache2.4 commands in htaccess
@atefBB

This comment has been minimized.

Copy link

commented on 64943cd Aug 9, 2018

@jonashrem Why did you include vendor folder !?

@jonashrem

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@ atefBB

what's wrong with it? The vendor folder has been there before. So I don't see any reason to exclude it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.