Repository navigation
Retain additional cron history by default - #11463
Merged
Merged
Conversation
There's no reason the clear the history out so fast other than to make it impossible to audit, if / when you have an issue.
davidalger
self-requested a review
October 15, 2017 00:05
davidalger
approved these changes
Oct 15, 2017
Member
|
@mpchadwick I wholeheartedly agree with this change. Let's see if I can't get it merged in! :) |
Member
|
@mpchadwick Would you be able to create PRs to apply this change to 2.2-develop and possibly 2.1-develop as well so it can make it into those release lines as well? |
mayankzalavadia
approved these changes
Oct 16, 2017
magento-team
pushed a commit
that referenced
this pull request
Oct 16, 2017
Contributor
Author
|
@davidalger will submit additional PRs against those branches when I have a moment. |
This was referenced Oct 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes default cron success / failure history to seven days.
There's no reason the clear the history out so fast other than to make it impossible to audit, if / when there is an issue...
Manual testing scenarios
Contribution checklist