New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain additional cron history by default #11463

Merged
merged 1 commit into from Oct 16, 2017

Conversation

@mpchadwick
Contributor

mpchadwick commented Oct 14, 2017

Description

Changes default cron success / failure history to seven days.

There's no reason the clear the history out so fast other than to make it impossible to audit, if / when there is an issue...

Manual testing scenarios

  1. In the admin panel go to Stores > Configuration > Advanced > System > Cron
  2. Validate that "Success History Lifetime" and "Failure History Lifetime" is 10080 for both the default and the index group.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
Retain additional cron history by default
There's no reason the clear the history out so fast other than
to make it impossible to audit, if / when you have an issue.

@davidalger davidalger self-requested a review Oct 15, 2017

@davidalger davidalger self-assigned this Oct 15, 2017

@davidalger

This comment has been minimized.

Member

davidalger commented Oct 15, 2017

@mpchadwick I wholeheartedly agree with this change. Let's see if I can't get it merged in! :)

@davidalger davidalger added this to the October 2017 milestone Oct 15, 2017

@davidalger davidalger added the develop label Oct 15, 2017

@magento-team magento-team moved this from TODO to Review In Progress in Community Pull Requests Oct 15, 2017

@davidalger

This comment has been minimized.

Member

davidalger commented Oct 15, 2017

@mpchadwick Would you be able to create PRs to apply this change to 2.2-develop and possibly 2.1-develop as well so it can make it into those release lines as well?

@magento-team magento-team moved this from Review In Progress to Merging In Progress in Community Pull Requests Oct 15, 2017

@magento-team magento-team merged commit 8609e0e into magento:develop Oct 16, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@mpchadwick

This comment has been minimized.

Contributor

mpchadwick commented Oct 16, 2017

@davidalger will submit additional PRs against those branches when I have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment