Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow coupon code with special charater to be applied to order in checkout #11710

Merged
merged 1 commit into from Oct 26, 2017

Conversation

gabrielqs-redstage
Copy link

@gabrielqs-redstage gabrielqs-redstage commented Oct 25, 2017

Fixes issue where coupon with special char (ex: %) could not be applied to quote in checkout, payment step

Description

Encoding of coupon code prior to requesting it to be applied

Fixed Issues (if relevant)

  1. When go checkout,Cart Price Rules 25%test coupon code can go wrong #9763: When go checkout,Cart Price Rules 25%test coupon code can go wrong

Manual testing scenarios

  1. In the admin, create a shopping cart price rule, and set it to use a coupon code, specify the coupon code to be 25%off. Set very broad conditions - preferably none - select all websites and all user groups.
  2. In the frontend, add a product to cart
  3. Proceed to checkout, type in address and select shipping method. It makes no difference if you're logged in as a customer or not
  4. Proceed to the payment method step and apply the coupon code 25%off. The coupon code will be applied correctly

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this Oct 25, 2017
@miguelbalparda miguelbalparda added this to the October 2017 milestone Oct 25, 2017
@miguelbalparda miguelbalparda added Release Line: 2.2 2.2.x bug report Component: Checkout Component: Tax Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 25, 2017
@magento-team magento-team merged commit fb84267 into magento:2.2-develop Oct 26, 2017
magento-team pushed a commit that referenced this pull request Oct 26, 2017
magento-team pushed a commit that referenced this pull request Oct 26, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82724 Allow coupon code with special charater to be applied to order in checkout #11710
 - MAGETWO-82675 Add a health check to the NGINX configuration sample #11690
 - MAGETWO-82562 Coupon codes not showing in invoice #11635
 - MAGETWO-82535 Fixed ability to set field config from layout xml #11302 [backport 2.2] #11643
 - MAGETWO-81146 Fixing #10275 keyboard submit of adminhtml suggest form. #11250
 - MAGETWO-82761 [Backport 2.2-develop] Dashboard Fix Y Axis for range #11751
 - MAGETWO-82748 Fix Notice: freePackageValue is undefined #11720
 - MAGETWO-82747 [TASK] Updated user.ini according to Magento DevDocs #11734
 - MAGETWO-82537 MAGETWO-81311: Check the length of the array before attempting to sli… #11637
 - MAGETWO-81970 Add missing translations in Magento_UI #11440
 - MAGETWO-81904 FIX #11022 in 2.2-develop: Filter Groups of search criteria parameter have not been included for further processing #11421
 - MAGETWO-82179 Fix Filter Customer Report Review 2.2-develop [Backport] #11522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Checkout Component: Tax Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants