Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we add another region column with ISO_3166-2 codes #1193

Closed
joh-klein opened this issue Apr 16, 2015 · 5 comments
Closed

Can we add another region column with ISO_3166-2 codes #1193

joh-klein opened this issue Apr 16, 2015 · 5 comments
Assignees

Comments

@joh-klein
Copy link

The current region codes for Germany seem not to be widely known (a quick Google search didn't reveal a source for them). And some others seem to be impractical but most importantly will probably hinder exchanging addresses with other systems.
I could provide a PR with the current data for regions from Wikipedia for these 13 countries (US, CA, DE, AT, CH, ES, FR, RO, FI, EE, LV, LT, BR). Right now I lean towards adding another column for backwards compatibility.

Quick link to relevant source code:
https://github.com/magento/magento2/blob/develop/app/code/Magento/Directory/Setup/InstallData.php#L300

@joh-klein joh-klein changed the title Can we add a ISO_3166-2 column with region codes Can we add another region column with ISO_3166-2 codes Apr 16, 2015
@vpelipenko
Copy link
Contributor

Hi @joh-klein, you can read more about labels here http://devdocs.magento.com/guides/v1.0/contributor-guide/CONTRIBUTING.html#labels. This label means that issue should be reviewed and accepted by our Product Team.

@joh-klein
Copy link
Author

joh-klein commented Apr 20, 2015

Thanks! I just found it myself and deleted my original comment for rtfm reasons :)

@pboisvert
Copy link

@piotrekkaminski Piotr--would you be the right owner here?

@piotrekkaminski
Copy link
Contributor

@pboisvert actually @antboiko as it is i18n issue. I've created internal issue MAGETWO-52665 to track this request.

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

magento-team pushed a commit that referenced this issue Jan 11, 2018
…ntax[forwardport]. #1193

 - Merge Pull Request magento-engcom/magento2ce#1193 from nmalevanec/magento2:12499
 - Merged commits:
   1. 6d86db1
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Jun 22, 2018
Fix modularity of InventoryShipping module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants