Solve problem saving empty swatches in admin

[enriquei4]

Description

Solve problem saving empty swatches in admin remving html ement instead of add hidden.

Fixed Issues (if relevant)

1. Swatch Attribute is not getting save while deleting a swatch row with empty admin scope text Swatch Attribute is not getting save while deleting a swatch row with empty admin scope text #13117

Manual testing scenarios

1. Login to admin and Goto Store- >Attribute->Product
2. Find a attribute like color
3. Open color attribute and make it to Visual Swatch type
4. In Manage Swatches section add color swatches
5. Now Click on Add Swatch button, a row will appear just remove it without filling anything into it.
6. Now is saved. Before it throws: The value of Admin scope can't be empty.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[enriquei4]

@serhii-balko i commited with a different email, i created this new PR to clean: #13154

[orlangur]

Better use if(!empty($options['delete'][$key])).

[serhii-balko]

You should also add a new test cases with empty 'deleted' options in https://github.com/magento/magento2ce/blob/2.3-develop/app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Attribute/ValidateTest.php#L325

[enriquei4]

Hi guys, i fixed the dataprovider it had a mistake, now is solved. $isError should be "false"

[serhii-balko]

the best way to test this case: add new cases in provideEmptyOption provider like this

'empty admin scope options and deleted' => [
                [
                    'value' => [
                        "option_0" => [''],
                    ],
                    'delete' => [
                        'option_0' => '1',
                    ],
                ],
                (object) [
                    'error' => false,
                ],
            ],
            'empty admin scope options and not deleted' => [
                [
                    'value' => [
                        "option_0" => [''],
                    ],
                    'delete' => [
                        'option_0' => '0',
                    ],
                ],
                (object) [
                    'error' => true,
                    'message' => 'The value of Admin scope can\'t be empty.',
                ],
            ],

[enriquei4]

Hi @serhii-balko should I remove the previous test case for testUniqueValidation?

[serhii-balko]

Yes, it will be better if you remove it

[enriquei4]

But that (first)case is working well, and is testing well the code. If i remove the new code (validate.php) the test fails, then i think that is useful.

[enriquei4]

@serhii-balko did you read my last comment :) (I understand that you could be busy)

[magento-engcom-team]

Yes, you are right, We approved this changes