Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2] Solve problem saving empty swatches in admin #13717

Merged

Conversation

@enriquei4
Copy link
Contributor

commented Feb 18, 2018

Description

Solve problem saving empty swatches in admin remving html ement instead of add hidden.

Fixed Issues (if relevant)

  1. Swatch Attribute is not getting save while deleting a swatch row with empty admin scope text #13117

Manual testing scenarios

  1. Login to admin and Goto Store- >Attribute->Product
  2. Find a attribute like color
  3. Open color attribute and make it to Visual Swatch type
  4. In Manage Swatches section add color swatches
  5. Now Click on Add Swatch button, a row will appear just remove it without filling anything into it.
  6. Now is saved. Before it throws: The value of Admin scope can't be empty.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@mzeis
mzeis approved these changes Mar 11, 2018

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 11, 2018

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2018

Hi @mzeis, thank you for the review.
ENGCOM-845 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 0fc6be3 into magento:2.2-develop Mar 13, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Mar 13, 2018
@mzeis

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2018

Hi @enriquei4, thanks for your PR! It has been merged into 2.2-develop.

@enriquei4 enriquei4 deleted the enriquei4:2_2_FIX-ADD-EMPTY-SWATCH branch Mar 13, 2018

@enriquei4

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2018

thanks @mzeis for you review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.