Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `^1.4` for `composer/composer` #14013

Merged
merged 1 commit into from Mar 9, 2018

Conversation

@sandermangel
Copy link
Contributor

commented Mar 8, 2018

Some modules require a more recent version of composer. To allow for this we use "^1.4" for the composer version

Description

Using the "1.4 and above" will mean it's backwards compatible for current use of 1.4 and uses newer versions in installations where possible.
This will allow for installing modules that use newer versions

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
Use `^1.4` for `composer/composer`
Some modules require a more recent version of composer. To allow for this we use "^1.4" for the composer version
@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

CLA assistant check
All committers have signed the CLA.

@miguelbalparda miguelbalparda self-assigned this Mar 8, 2018

@miguelbalparda

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

Thanks for your contribution Sander! This is going to be reviewed soon, I'll let you know if we have questions!

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

Hi @miguelbalparda, thank you for the review.
ENGCOM-809 has been created to process this Pull Request

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

@sandermangel thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sandermangel

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2018

@magento-engcom-team thanks guys, happy to see this going through!

@magento-engcom-team magento-engcom-team merged commit 8be7e1c into magento:2.2-develop Mar 9, 2018

2 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Mar 9, 2018
@rostyslav-hymon rostyslav-hymon referenced this pull request Mar 21, 2018
2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.