Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#10057 #14327

Merged
merged 1 commit into from Mar 27, 2018

Conversation

@swnsma
Copy link
Contributor

commented Mar 24, 2018

Description

Current Pull Request contains fix for issue #10057 .
Problem related to products with configured backorder.
If you place order with backorder product from frontend - everything work properly: backorder order items will have status 'Backordered'.
But when you try to place order/edit/reorder from backoffice, backorder products will not have 'Backorder' status.

Fixed Issue

  1. #10057: Editing order with backordered items results in new order not correctly marking order items as backordered.

Manual testing scenarios

Steps to reproduce

  1. Set a product up as backorderable - 0 quantity stock, "allow orders below 0", in stock, enabled.
  2. Go to BO -> Sales -> Operations -> Orders -> Create New Order
  3. Create new order with backorderable product.
  4. Check order item details which was created from backorderable product.

Expected result

  1. Order item has status 'Backordered'.

Actual result

  1. Order item has status 'Ordered'.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2018

CLA assistant check
All committers have signed the CLA.

@osrecio

This comment has been minimized.

Copy link
Member

commented Mar 24, 2018

Please @swnsma sign the CLA to proceed with your PR.
Thanks!

@swnsma swnsma requested a review from vzabaznov Mar 25, 2018

#10057
Fix backordering from Adminhtml.
Initialize 'backorder' value for quote items even if Quote has Super Mode enabled.

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 27, 2018

@sidolov sidolov removed the request for review from vzabaznov Mar 27, 2018

@magento-engcom-team magento-engcom-team merged commit 9addb44 into magento:2.2-develop Mar 27, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Mar 27, 2018
@mastiuhin-olexandr mastiuhin-olexandr referenced this pull request Mar 29, 2018
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.