New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix bug with retry connect and custom db port #14753

Merged
merged 2 commits into from Apr 22, 2018

Conversation

3 participants
@julienanquetil
Copy link
Contributor

julienanquetil commented Apr 18, 2018

Original Pull Request
#14435
Fix a bug in the MySQL adapter when using non standard port

Manual testing scenarios
Use a database config with port, e.g. localhost:3307
On first call to _connect(), the config['host'] parameter is split into config['host'] and config['port']
In the _query() function, a situation happens that is suitable for a retry (e.g. a "MySQL has gone away" error)
_connect() is called again
Expected result
Connection is reestablished and query tried again

Actual result
"Port must be configured within host parameter" exception

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

julienanquetil added some commits Apr 18, 2018

[Backport] Fix bug with retry connect and custom db port
Original Pull Request
#14435
Fix a bug in the MySQL adapter when using non standard port

Manual testing scenarios
Use a database config with port, e.g. localhost:3307
On first call to _connect(), the config['host'] parameter is split into config['host'] and config['port']
In the _query() function, a situation happens that is suitable for a retry (e.g. a "MySQL has gone away" error)
_connect() is called again
Expected result
Connection is reestablished and query tried again

Actual result
"Port must be configured within host parameter" exception

@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 18, 2018

@magento-engcom-team magento-engcom-team moved this from TODO to Testing In Progress in Community Pull Requests Apr 18, 2018

@magento-engcom-team magento-engcom-team moved this from Testing In Progress to Merging In Progress in Community Pull Requests Apr 20, 2018

magento-team pushed a commit that referenced this pull request Apr 22, 2018

@magento-engcom-team magento-engcom-team merged commit fbc2646 into magento:2.2-develop Apr 22, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

Community Pull Requests automation moved this from Merging In Progress to Done Apr 22, 2018

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Apr 22, 2018

Hi @julienanquetil. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment