New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the length of the remote_ip field to store ipv6 addresses #14976

Merged
merged 2 commits into from May 7, 2018

Conversation

@georgeschiopu
Member

georgeschiopu commented May 3, 2018

Expands the remote_ip field to 45 characters in both the sales_order and quote tables, to cope with the ipv6 addresses, otherwise they get truncated.

Fixed Issues (if relevant)

  1. #10395 : REMOTE_IP gets saved partially when using IPV6

Manual testing scenarios

  1. trigger a bin/magento setup:upgrade and check both tables mentioned to check for the changes; also, check the versions of the modules in setup_module

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
George Schiopu
@magento-cicd2

This comment has been minimized.

Contributor

magento-cicd2 commented May 3, 2018

CLA assistant check
All committers have signed the CLA.

George Schiopu
MAGETWO-83202: code refactoring, separate into different methods #10395
Signed-off-by: George Schiopu <george@space48.com>
@magento-engcom-team

This comment has been minimized.

Contributor

magento-engcom-team commented May 4, 2018

Hi @miguelbalparda, thank you for the review.
ENGCOM-1441 has been created to process this Pull Request

@magento-engcom-team

This comment has been minimized.

Contributor

magento-engcom-team commented May 4, 2018

@georgeschiopu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team moved this from TODO to Testing In Progress in Community Pull Requests May 4, 2018

@magento-engcom-team magento-engcom-team moved this from Testing In Progress to Merging In Progress in Community Pull Requests May 4, 2018

@magento-engcom-team magento-engcom-team merged commit a08f378 into magento:2.2-develop May 7, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

Community Pull Requests automation moved this from Merging In Progress to Done May 7, 2018

magento-engcom-team pushed a commit that referenced this pull request May 7, 2018

@magento-engcom-team

This comment has been minimized.

Contributor

magento-engcom-team commented May 7, 2018

Hi @georgeschiopu. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@miguelbalparda

This comment has been minimized.

Collaborator

miguelbalparda commented May 7, 2018

Thanks @georgeschiopu! Any chance you can backport this to the other branches?

@georgeschiopu

This comment has been minimized.

Member

georgeschiopu commented May 8, 2018

Hi @miguelbalparda , I'll try to do so this week.
Thanks for the review btw, didn't got a chance to thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment