New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13415 : Duplicated elements id #15585

Merged
merged 3 commits into from Jun 2, 2018

Conversation

@julienanquetil
Copy link
Contributor

julienanquetil commented May 29, 2018

Description

Fixed Issues (if relevant)

  1. #13415: Duplicated elements id in checkout page
  2. ...

Manual testing scenarios

  1. Chrome didn't display error in console related to non unique ID
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

julienanquetil added some commits May 29, 2018

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone May 30, 2018

@magento-engcom-team magento-engcom-team moved this from TODO to Merging In Progress in Community Pull Requests Jun 1, 2018

@magento-engcom-team magento-engcom-team merged commit b90d93d into magento:2.2-develop Jun 2, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
licence/cla Contributor License Agreement is signed.
Details

Community Pull Requests automation moved this from Merging In Progress to Done Jun 2, 2018

magento-engcom-team pushed a commit that referenced this pull request Jun 2, 2018

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jun 2, 2018

Hi @julienanquetil. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment