Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Use stored value of method instead of calling same method again. #15706

Merged
merged 3 commits into from Jun 5, 2018
Merged

[Forwardport] Use stored value of method instead of calling same method again. #15706

merged 3 commits into from Jun 5, 2018

Conversation

dmytro-ch
Copy link
Contributor

Original Pull Request

#15517
Use stored value of method instead of calling same method again.

Description

$block->getPartners() is stored in variable name $partners. So it should use the variable value instead of calling $block->getPartners() again.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. Check the currency drop-down in frontend part.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Marketplace labels Jun 3, 2018
@dmytro-ch dmytro-ch requested a review from rogyar June 3, 2018 07:54
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 3, 2018
@magento-engcom-team magento-engcom-team merged commit 42f3f2e into magento:2.3-develop Jun 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2018
@VladimirZaets
ENGCOM-1790: [Forwardport] Use stored value of method instead of call…
4c7a33d 
…ing same method again. #15706
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

Labels
Area: Frontend Component: Marketplace Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmytro-ch @magento-engcom-team @rogyar