Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport 2.3] Trim username on customer account login page #15884

Merged

Conversation

dankhrapiyush
Copy link
Contributor

Original Pull Request

#15365

Trim email address on customer account login page generally when copy and paste.

Description

Trim email address by remove leading or trailing space on the customer account login page email field.

Fixed Issues (if relevant)

  1. IE11 user login email validation fails if field has leading or trailing space #6058: IE11 user login email validation fails if field has leading or trailing space

Manual testing scenarios

  1. Open customer account login page in Firefox or IE browser.
  2. Try to add space before entering an email address in the Email field.
  3. Copy " johndoe@domain.com " and paste in the Email field. It will automatically remove leading or trailing space.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Contributor

Hi, @dankhrapiyush, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

Hi @dankhrapiyush. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants