Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGETWO-61209: Issue #7379 Calendar widget (jQuery UI DatePicker) with numberOfMonths = 2 or more #16278

Conversation

vasilii-b
Copy link

Description

The full description of the issue and steps to reproduce are provided in #7379.
The same issue is reproduced on Magento 2.1, Magento 2.2 and Magento 2.3-develop

Fixed Issues

  1. Calendar widget (jQuery UI DatePicker) with numberOfMonths = 2 or more #7379: Calendar widget (jQuery UI DatePicker) with numberOfMonths = 2 or more

Manual testing scenarios

The easiest way to see the issue in action is to add a new field in the Magento_Contact form that is gonna use a calendar.

Field to add:

<div class="field availability">
  <label class="label" for="availability"><span><?= $block->escapeHtml(__('Availability')) ?></span></label>
   <div class="control">
       <input name="availability" id="availability" title="<?= $block->escapeHtmlAttr(__('Availability')) ?>"
            value="<?= $block->escapeHtmlAttr($this->helper('Magento\Contact\Helper\Data')->getPostValue('availability')) ?>" class="input-text" type="text" />
  </div>
</div>

Initialize the calendar:

<script>
    require(['jquery', 'mage/calendar'], function($, calendar) {
       $('#availability').calendar({
           numberOfMonths: [1, 2]
       });
    });
</script>

You should see only 2 months displayed, like this:
image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Vasilii Burlacu added 2 commits June 20, 2018 22:52
…calendar-widget-number-of-months

* origin/2.3-develop:
  MAGETWO-91545: Error not found page issue in change status and update attribute from product grid
  MAGETWO-91545: Error not found page issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page ” issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page ” issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page ” issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page ” issue in change status and update attribute from product grid
  MAGETWO-91545: Error not found page issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page ” issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page ” issue in change status and update attribute from product grid
  MAGETWO-91545: 404 Error not found page ” issue in change status and update attribute from product grid
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Jun 22, 2018

@vasilii-b thank you for your collaboration. Start from the 2.2-develop branch next time, please, and then port the solution after it's approved.

@vasilii-b
Copy link
Author

@rogyar thank you! Will do the next time.

@magento-engcom-team magento-engcom-team merged commit e874ff0 into magento:2.3-develop Jun 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@vasilii-b vasilii-b deleted the MAGETWO-61209-calendar-widget-number-of-months_mage23 branch June 30, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants