Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Resolved : JS files located outside the web/js directory #16582
Some JS files are direct children of
Fixed Issues (if relevant)
Hi @hitesh-wagento. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation
changed the title
[Resolved : JS files located outside the web/js directory]
Jul 6, 2018
you should to do it for each cases.
also you should add `'Magento_Captcha/captcha': 'Magento_Captcha/js/captcha'
Aug 7, 2018
moved this from Ready to Port
to Port to 2.3 Created
in Ports Wanted
Aug 7, 2018
I'm not sure it's the best of places to address that, but I didn't want to re-open #16302 by adding a comment to it.
My issue is it seems the changes seem to be BC under some conditions.
For instance, if in a 2.2.5 :
'mageQuickSearch' being there to be referenced as a define() dependency in 'Third_PartyModule/js/form-mini'.
Problem: The path mapping is not taken into account, either in blank or luma, in developer or production modes : a 404 error is thrown for ".../Magento_Search/form-mini.js".
IF I remove "mageQuickSearch" from the third party requirejs-config.js and replace it in the 'Third_PartyModule/js/form-mini' define() by the native/legacy path 'Magento_Search/form-mini', then it works as expected.
Am I missing something or does that mean there is still a risk of BC break across the board ?