Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGETWO-84608: Cannot perform setup:install if Redis needs a password… #17078

Merged

Conversation

@guillaumegiordana
Copy link
Contributor

commented Jul 24, 2018

Description

Needed to perform setup on a fresh magento install using an authenticated redis instance for the cache configuration part.
Redis session password configuration works whereas the cache configuration does not take the provided configuration.
Changed setup/src/Magento/Setup/Model/ConfigOptionsList/Cache.php and setup/src/Magento/Setup/Model/ConfigOptionsList/PageCache.php to enable a configuration password during initial setup.

Fixed Issues (if relevant)

  1. magento/magento2#MAGETWO-84608: Redis password not used when trying to validate the connection during install.

Manual testing scenarios

  1. Setup a new magento instance with bin/magento setup:install with cache options in env.php as so :
    'cache' => [ 'frontend' => [ 'default' => [ 'backend' => 'Cm_Cache_Backend_Redis', 'backend_options' => [ 'server' => redis_host, 'database' => '0', 'port' => 6379, 'password' => redis_password ] ], 'page_cache' => [ 'backend' => 'Cm_Cache_Backend_Redis', 'backend_options' => [ 'server' => redis_host, 'port' => 6379, 'database' => '1', 'compress_data' => '0', 'password' => redis_password ] ] ] ],

The setup will fail saying that the redis configuration is wrong.

Contribution checklist

  • [X ] Pull request has a meaningful description of its purpose
  • [X ] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2018

Hi @guillaumegiordana. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@guillaumegiordana guillaumegiordana force-pushed the guillaumegiordana:MAGETWO-84608 branch 2 times, most recently from 7749a2e to b15e614 Jul 24, 2018

MAGETWO-84608: Cannot perform setup:install if Redis needs a password…
… and Redis page cache is enabled in env.php
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2018

@guillaumegiordana thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 6bc40ea into magento:2.2-develop Aug 8, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2018
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

Hi @guillaumegiordana. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@magento-engcom-team magento-engcom-team added this to Ready to Port in Ports Wanted Aug 8, 2018

@magento-engcom-team magento-engcom-team moved this from Ready to Port to Port to 2.3 Created in Ports Wanted Aug 8, 2018

@magento-engcom-team magento-engcom-team moved this from Port to 2.3 Created to Port to 2.3 Merged in Ports Wanted Aug 11, 2018

@keharper keharper referenced this pull request Oct 4, 2018
4 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.