Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JS code and added JS component file #17527

Merged

Conversation

@yogeshsuhagiya
Copy link
Member

commented Aug 11, 2018

Description

Created a new JS component with the callback function.
Replaced <script/> tag with <script type="text/x-magento-init" />

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2018

Hi @yogeshks. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Aug 11, 2018


return function (config, element) {

jQuery(element).mage('form').mage('validation', {

This comment has been minimized.

Copy link
@VladimirZaets

VladimirZaets Aug 11, 2018

Contributor

Hi @yogeshks. Thanks for the collaboration. Please use $ alias to jQuery instead of jQuery

This comment has been minimized.

Copy link
@yogeshsuhagiya

yogeshsuhagiya Aug 11, 2018

Author Member

Hello @VladimirZaets , sure I'll do.

@VladimirZaets

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2018

@yogeshks Thanks

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2018

Hi @VladimirZaets, thank you for the review.
ENGCOM-2748 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 0c1104f into magento:2.2-develop Aug 14, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
licence/cla Contributor License Agreement is signed.
Details
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2018

Hi @yogeshks. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@magento-engcom-team magento-engcom-team added this to Ready to Port in Ports Wanted Aug 14, 2018

@magento-engcom-team magento-engcom-team moved this from Ready to Port to Port to 2.3 Created in Ports Wanted Aug 15, 2018

@magento-engcom-team magento-engcom-team moved this from Port to 2.3 Created to Ready to Port in Ports Wanted Aug 30, 2018

ishakhsuvarov added a commit to yogeshsuhagiya/magento2 that referenced this pull request Sep 12, 2018

@ishakhsuvarov ishakhsuvarov moved this from Ready to Port to Port to 2.3 Created in Ports Wanted Sep 12, 2018

@magento-engcom-team magento-engcom-team moved this from Port to 2.3 Created to Port to 2.3 Merged in Ports Wanted Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.