Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Added Unit Test for WindowsSmtpConfig Plugin #18835

Merged

Conversation

@vasilii-b
Copy link
Contributor

vasilii-b commented Oct 26, 2018

Original Pull Request

#18694

Description

This PR cover Magento\Email\Test\Unit\Model\Plugin\WindowsSmtpConfig plugin with unit test.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 26, 2018

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 26, 2018
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 26, 2018

Hi @VladimirZaets, thank you for the review.
ENGCOM-3289 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 4f5cb9b into magento:2.2-develop Oct 29, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
licence/cla Contributor License Agreement is signed.
Details
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 29, 2018

Hi @vasilii-b. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@magento-engcom-team magento-engcom-team added this to Ready to Port in Ports Wanted Oct 29, 2018
@sidolov sidolov removed this from Ready to Port in Ports Wanted Oct 29, 2018
@vasilii-b vasilii-b deleted the vasilii-b:2.2-develop-PR-port-18694 branch Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.