Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] fixed Translation issue send-friend in send.phtml #18886

Merged

Conversation

@rahulwebkul
Copy link
Contributor

rahulwebkul commented Oct 27, 2018

Description (*)

I think there is no need to use escapeJs method as we are already using escapeHtml method.
Due to this string getting converted in hexadecimal.

Fixed Issues (if relevant)

  1. #18779: Translation issue send-friend in sendphtml

Manual testing scenarios (*)

Add translation in module-send-friend module. put Name -> Na-me:. string will become Na\u002Dme\u003A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #18889

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 27, 2018

Hi @rahulwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 27, 2018
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 27, 2018

Hi @orlangur, thank you for the review.
ENGCOM-3301 has been created to process this Pull Request

@sidolov sidolov changed the title fixed Translation issue send-friend in send.phtml [Backport] fixed Translation issue send-friend in send.phtml Oct 29, 2018
@magento-engcom-team magento-engcom-team merged commit 443e681 into magento:2.2-develop Oct 29, 2018
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Oct 29, 2018
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 29, 2018

Hi @rahulwebkul. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@magento-engcom-team magento-engcom-team added this to Ready to Port in Ports Wanted Oct 29, 2018
@sidolov sidolov removed this from Ready to Port in Ports Wanted Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.