Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix for currency update in crontab area #18980

Merged

Conversation

@denispapec
Copy link
Contributor

denispapec commented Oct 31, 2018

Description (*)

This PR fixes issue where cron doesn't updates currency rates if they aren't enabled in default store.
This PR is for 2.2 Release line.

Fixed Issues (if relevant)

  1. #18580: Currency rates not updated by crontab

Manual testing scenarios (*)

  1. Base store has only one allowed currency (EUR). So EUR is the base currency.
  2. English store has 4 allowed currencies (EUR, CAD, USD, GBP).
  3. Enable Fixer.io conversion service and enable it.
  4. Save manually incorrect rates for CAD, USD and GBP.
  5. Run cron currency_rates_update
  6. Confirm that all rates are updated to real values.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #18981

@magento-cicd2

This comment has been minimized.

Copy link
Contributor

magento-cicd2 commented Oct 31, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Oct 31, 2018

Hi @denispapec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Nov 1, 2018
@sidolov sidolov changed the title Fix for currency update in crontab area [Backport] Fix for currency update in crontab area Nov 1, 2018
Copy link

jcourtei left a comment

@denispapec Thanks!

@sidolov sidolov added this to Pending Review in Pull Requests Dashboard Feb 28, 2019
@sidolov sidolov moved this from Pending Review to Review in Progress in Pull Requests Dashboard Feb 28, 2019
@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Apr 3, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Apr 3, 2019

Hi @orlangur, thank you for the review.
ENGCOM-4660 has been created to process this Pull Request

@stoleksiy stoleksiy moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 9, 2019
@stoleksiy stoleksiy self-assigned this Apr 9, 2019
@stoleksiy

This comment has been minimized.

Copy link

stoleksiy commented Apr 10, 2019

✔️ QA Passed

@stoleksiy stoleksiy moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 10, 2019
@p-bystritsky p-bystritsky self-assigned this Apr 10, 2019
@p-bystritsky p-bystritsky moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 11, 2019
@magento-engcom-team magento-engcom-team merged commit 737f396 into magento:2.2-develop Apr 15, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@m2-assistant

This comment has been minimized.

Copy link

m2-assistant bot commented Apr 15, 2019

Hi @denispapec, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Apr 15, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 15, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 15, 2019
@sidolov sidolov removed this from Recently Merged in Pull Requests Dashboard May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.