New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Add/update newsletter messages in translation file #19118
[Backport] Add/update newsletter messages in translation file #19118
Conversation
Hi @arnoudhgz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
I know it is a cleanup, but we really need these translations in 2.2 👍 |
Hi @orlangur, thank you for the review. |
@arnoudhgz I would rather treat it as a bug - inability to localize something is a severe issue. |
Hi @VladimirZaets, thank you for the review. |
Hi @arnoudhgz. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Original Pull Request
#19050
Original PR: #18932 (was closed by me because of out-of-sync fork)
Description (*)
The messages in the Newsletter module were update, but the messages in the translation files have been forgotten.
When using translation tools it is mandatory to have correct strings in the i18n files. This pull request aims to solve this.
Manual testing scenarios (*)
Compare the messages in app/code/Magento/Newsletter/Controller/Manage/Save.php with the i18n file
Contribution checklist (*)