New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BackPort] resolve typos and correct variable names #19280
[BackPort] resolve typos and correct variable names #19280
Conversation
Hi @viral-wagento thanks for your contribution, can you please forwardport this pull request to 2.3 as well. Original pull request #16005 |
Hi @viral-wagento. Thanks for the collaboration. Please add the translation for "Allow Zero GrandTotal for Credit Memos" and "Allow Zero GrandTotal for Credit Memos" phrases to |
Unfortunately, we can't accept such Pull Requests to 2.2 release line, all code cleanup like typos, spelling mistakes, etc should be delivered to 2.3 release line. For more information, please, refer to Magento Code Contributions Guide. |
Hi @viral-wagento. As @orlangur said above firstly PR should be delivered to 2.3 Magento branch. Please create PR to 2.3 Magento branch. |
@VladimirZaets it is already merged to 2.3 in #19288. I would accept this one to 2.2 as it contains not just typo fixes but also missing translations. |
Hi @orlangur, thank you for the review. |
Hi @viral-wagento. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
@magento-engcom-team @sidolov |
Description
Fixed typos and added proper variable names in below files:
Original PR: #19288
app/code/Magento/Sales/Model/Order.php
app/code/Magento/Sales/etc/adminhtml/system.xml
Manual testing scenarios
app/code/Magento/Sales/Model/Order.php
Line:668 - replaced $hasActinFlag to $hasActionFlag
Line:688 - replaced $dueAmountCondition to $hasDueAmount
Line:690 - replaced $creditmemos to $creditMemos
app/code/Magento/Sales/etc/adminhtml/system.xml
Line:52 - replaced Allow Zero GrandTotal to Allow Zero GrandTotal for Credit Memos
Line:54 - replaced Allow Zero GrandTotal for Creditmemo to Allow Zero GrandTotal for Credit Memos
Contribution checklist (*)