Skip to content

Conversation

shochdoerfer
Copy link
Member

Corrected Quote item type hint.

@magento-engcom-team
Copy link
Contributor

Hi @shochdoerfer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3983 has been created to process this Pull Request

@rogyar rogyar assigned rogyar and unassigned orlangur Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3983 has been created to process this Pull Request

@orlangur
Copy link
Contributor

rogyar assigned rogyar and unassigned orlangur 15 minutes ago

@rogyar what?)

@rogyar
Copy link
Contributor

rogyar commented Jan 30, 2019

@orlangur I had this PR opened in a tab during some time, then assigned to myself (was unassigned). Looks like my request emptied the assignees. It wasn't for a purpose :)

@orlangur orlangur self-assigned this Jan 30, 2019
@orlangur
Copy link
Contributor

orlangur commented Jan 30, 2019

@rogyar yep, sometimes I have the same double approval. Thanks for clarification.

By the way, the bot assigns automatically after approval, no need for this manual action ;)

@magento-engcom-team magento-engcom-team merged commit 48a63ed into magento:2.3-develop Feb 1, 2019
@ghost
Copy link

ghost commented Feb 1, 2019

Hi @shochdoerfer, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants