Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Gift-option-message-overlap-edit-and-remove-button-2.2 #20784

Conversation

@ajay2jcommerce
Copy link

ajay2jcommerce commented Jan 30, 2019

Description (*)

#20604

Fixed Issues (if relevant)

  1. #20605: Gift option massage overlap edit and remove button
  2. Magento 2.2.x

Manual testing scenarios (*)

  1. Login Admin
  2. Go to Store >> Configuration >> sales >> sales >>gift option>> enable both settings
  3. add product to cart.
  4. add gift option massage.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jan 30, 2019

Hi @ajay2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jan 30, 2019

Hi @sidolov, thank you for the review.
ENGCOM-4058 has been created to process this Pull Request

@sdzhepa

This comment has been minimized.

Copy link
Contributor

sdzhepa commented Jan 31, 2019

@magento-engcom-team give me test instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jan 31, 2019

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jan 31, 2019

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20784.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team merged commit adf8d4c into magento:2.2-develop Feb 4, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Feb 4, 2019

Hi @ajay2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 4, 2019
…utton-2.2 #20784
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.