Enabled 'Shopping Cart' tab for customer edit interface in admin #20918

rav-redchamps · 2019-02-03T08:52:18Z

Description (*)

Fixed Issues (if relevant)

Customer Admin Shopping Cart View Missing #6287: Customer Admin Shopping Cart View Missing

Manual testing scenarios (*)

Navigated to 'Customers > All Customers > Edit Specific Customer' in admin and verified the visibility of 'Shopping Cart' tab and its content grid
Added few products to customer's cart in frontend and verified their visibility in 'Shopping Cart' tab
Tested product 'Delete' and 'Configure' actions in the tab

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-cicd2 · 2019-02-03T08:52:20Z

All committers have signed the CLA.

magento-engcom-team · 2019-02-03T08:52:22Z

Hi @rav-redchamps. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

rav-redchamps · 2019-02-03T09:23:20Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-02-03T09:23:22Z

Hi @rav-redchamps. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-02-03T09:23:56Z

Hi @rav-redchamps, here is your new Magento instance.
Admin access: https://pr-20918.instances.magento-community.engineering/admin
Login: admin Password: 123123q

rav-redchamps · 2019-02-04T11:20:16Z

@magento-engcom-team seems like the Travis automated tests stucked. It is running for more than 24 hours. Kindly check.

magento-engcom-team · 2019-02-05T12:48:39Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4126 has been created to process this Pull Request

magento-engcom-team · 2019-02-05T12:48:40Z

@rav-redchamps thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

sivaschenko · 2019-02-06T12:22:17Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-02-06T12:22:17Z

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-02-06T12:23:24Z

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20918.instances.magento-community.engineering/admin
Login: admin Password: 123123q

…pping-cart-tab

sivaschenko

Hi @rav-redchamps , thanks for the pull request!

Public methods should not be added to classes marked as API without approval by the architect because of backward compatibility concerns.

Please consider introducing a new block class implementing TabInterface to avoid adding new public methods to an API class?

rav-redchamps · 2019-03-06T15:18:27Z

@sivaschenko make sense. Will do it by tomorrow via introducing a new block class implementing TabInterface

… methods from API block class

…/magento2 into customer-shopping-cart-tab

rav-redchamps · 2019-03-07T07:30:06Z

@sivaschenko just pushed the changes. Please have a look

ihor-sviziev · 2019-05-20T05:25:04Z

Hi @sivaschenko,
Could you clarify why this PR was moved to "On hold"?

sivaschenko

Hi @rav-redchamps , thanks for your patience! Unfortunately, we couldn't approve the newly introduced usage of deprecated Registry. Can you please replace it with i.e. service class storing the current customer id.

sivaschenko · 2019-05-28T11:24:06Z

app/code/Magento/Sales/Block/Adminhtml/ShoppingCartsTab.php

+     */
+    public function canShowTab()
+    {
+        return $this->coreRegistry->registry(RegistryConstants::CURRENT_CUSTOMER_ID);


The registry is a deprecated class, please use another way to retrieve the current customer id. I.e. passing through an introduced service class.

For example, introduce a class that will init customer id from the request and provide a method to retrieve this customer id.

sivaschenko · 2019-05-28T11:29:52Z

@ihor-sviziev the pull request was put on hold as I needed to discuss and decide on whether the registry usage, in this case, can be accepted

…pping-cart-tab

…e in admin.

p-bystritsky · 2019-06-13T11:42:16Z

@sivaschenko PR updated, please review.

magento-engcom-team · 2019-06-13T12:26:48Z

Hi @sivaschenko, thank you for the review.
ENGCOM-4126 has been created to process this Pull Request

makkoff · 2019-06-13T14:00:20Z

✔️ QA Passed

nelero · 2019-07-05T10:37:23Z

hi,
any news on it ? can we use the PR or still buggy ?
Thanks

m2-assistant · 2019-07-06T14:41:35Z

Hi @rav-redchamps, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…in admin #20918

Enabled 'Shopping Cart' tab for customer edit interface in admin

e062906

magento-engcom-team added Area: Frontend Component: Customer Component: Sales Release Line: 2.3 labels Feb 3, 2019

suneet64 added the Event: mm19in label Feb 3, 2019

ihor-sviziev approved these changes Feb 5, 2019

View reviewed changes

magento-engcom-team assigned ihor-sviziev Feb 5, 2019

rav-redchamps mentioned this pull request Feb 7, 2019

Customer Admin Shopping Cart View Missing #6287

Closed

pfortin-expertime mentioned this pull request Feb 28, 2019

Delete only on first Item and click links to product edit pfortin-expertime/MageFix-Customer#2

Open

Merge remote-tracking branch 'mainline/2.3-develop' into customer-sho…

ae5b032

…pping-cart-tab

sivaschenko requested changes Mar 6, 2019

View reviewed changes

ghost added the Progress: needs update label Mar 6, 2019

rav-redchamps added 2 commits March 7, 2019 12:50

Created separate block class inheriting TabWrapper and removed public…

1a73182

… methods from API block class

Merge branch 'customer-shopping-cart-tab' of github.com:rav-redchamps…

33e702e

…/magento2 into customer-shopping-cart-tab

ihor-sviziev requested review from sivaschenko and ihor-sviziev March 11, 2019 09:17

ghost added the Progress: on hold label Apr 26, 2019

sivaschenko requested changes May 28, 2019

View reviewed changes

ghost added Progress: needs update and removed Progress: on hold labels May 28, 2019

p-bystritsky added 2 commits June 13, 2019 14:26

Merge remote-tracking branch 'mainline/2.3-develop' into customer-sho…

6d9d7f0

…pping-cart-tab

magento#20918: Enabled 'Shopping Cart' tab for customer edit interfac…

9e07d6e

…e in admin.

p-bystritsky removed the Progress: needs update label Jun 13, 2019

p-bystritsky requested a review from sivaschenko June 13, 2019 11:41

sivaschenko approved these changes Jun 13, 2019

View reviewed changes

ghost added the Progress: ready for testing label Jun 13, 2019

magento#20918: Removed Registry from the use block

bca244c

sivaschenko approved these changes Jun 13, 2019

View reviewed changes

makkoff self-assigned this Jun 13, 2019

ghost added Progress: testing in progress Progress: extended testing Progress: accept and removed Progress: ready for testing Progress: testing in progress Progress: extended testing labels Jun 13, 2019

magento-engcom-team merged commit bca244c into magento:2.3-develop Jul 6, 2019

magento-engcom-team added this to the Release: 2.3.3 milestone Jul 6, 2019

magento-engcom-team pushed a commit that referenced this pull request Jul 6, 2019

ENGCOM-4126: Enabled 'Shopping Cart' tab for customer edit interface …

943afc6

…in admin #20918

sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enabled 'Shopping Cart' tab for customer edit interface in admin #20918

Enabled 'Shopping Cart' tab for customer edit interface in admin #20918

rav-redchamps commented Feb 3, 2019 •

edited

Loading

magento-cicd2 commented Feb 3, 2019 •

edited

Loading

magento-engcom-team commented Feb 3, 2019

rav-redchamps commented Feb 3, 2019

magento-engcom-team commented Feb 3, 2019

magento-engcom-team commented Feb 3, 2019

rav-redchamps commented Feb 4, 2019

magento-engcom-team commented Feb 5, 2019

magento-engcom-team commented Feb 5, 2019

sivaschenko commented Feb 6, 2019

magento-engcom-team commented Feb 6, 2019

magento-engcom-team commented Feb 6, 2019

sivaschenko left a comment

rav-redchamps commented Mar 6, 2019

rav-redchamps commented Mar 7, 2019

ihor-sviziev commented May 20, 2019

sivaschenko left a comment

sivaschenko May 28, 2019

sivaschenko Jun 3, 2019 •

edited

Loading

sivaschenko commented May 28, 2019

p-bystritsky commented Jun 13, 2019

magento-engcom-team commented Jun 13, 2019

makkoff commented Jun 13, 2019

nelero commented Jul 5, 2019

m2-assistant bot commented Jul 6, 2019

Enabled 'Shopping Cart' tab for customer edit interface in admin #20918

Enabled 'Shopping Cart' tab for customer edit interface in admin #20918

Conversation

rav-redchamps commented Feb 3, 2019 • edited Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

magento-cicd2 commented Feb 3, 2019 • edited Loading

magento-engcom-team commented Feb 3, 2019

rav-redchamps commented Feb 3, 2019

magento-engcom-team commented Feb 3, 2019

magento-engcom-team commented Feb 3, 2019

rav-redchamps commented Feb 4, 2019

magento-engcom-team commented Feb 5, 2019

magento-engcom-team commented Feb 5, 2019

sivaschenko commented Feb 6, 2019

magento-engcom-team commented Feb 6, 2019

magento-engcom-team commented Feb 6, 2019

sivaschenko left a comment

Choose a reason for hiding this comment

rav-redchamps commented Mar 6, 2019

rav-redchamps commented Mar 7, 2019

ihor-sviziev commented May 20, 2019

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko May 28, 2019

Choose a reason for hiding this comment

sivaschenko Jun 3, 2019 • edited Loading

Choose a reason for hiding this comment

sivaschenko commented May 28, 2019

p-bystritsky commented Jun 13, 2019

magento-engcom-team commented Jun 13, 2019

makkoff commented Jun 13, 2019

nelero commented Jul 5, 2019

m2-assistant bot commented Jul 6, 2019

rav-redchamps commented Feb 3, 2019 •

edited

Loading

magento-cicd2 commented Feb 3, 2019 •

edited

Loading

sivaschenko Jun 3, 2019 •

edited

Loading