Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast attribute ID to integer - Fixes #20969 #20971

Merged
merged 2 commits into from Feb 19, 2019
Merged

Cast attribute ID to integer - Fixes #20969 #20971

merged 2 commits into from Feb 19, 2019

Conversation

k4emic
Copy link

@k4emic k4emic commented Feb 4, 2019

Fixes #20969

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 4, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @k4emic. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: CatalogSearch Release Line: 2.3 Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner labels Feb 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4109 has been created to process this Pull Request

@sivaschenko sivaschenko self-assigned this Feb 18, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Feb 19, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 77b0ae8 into magento:2.3-develop Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

Hi @k4emic, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 19, 2019
@sidolov
ENGCOM-4109: Cast attribute ID to integer - Fixes #20969 #20971
93b6933
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sivaschenko sivaschenko

@sidolov sidolov

Labels
Award: bug fix Component: CatalogSearch Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k4emic @magento-cicd2 @magento-engcom-team @sidolov @sivaschenko