Skip to content

Conversation

maddumarala
Copy link
Contributor

@maddumarala maddumarala commented Feb 6, 2019

Description (*)

Removed array $data parameter of constructor class in Magento\Ui\Model\UiComponentGenerator.
Number,type of parameters used in PHPDoc comment does not match with ones in respective function.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maddumarala. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Ui Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Feb 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4162 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@maddumarala thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@osrecio osrecio self-assigned this Feb 7, 2019
@magento-engcom-team magento-engcom-team merged commit 81571df into magento:2.3-develop Feb 12, 2019
@ghost
Copy link

ghost commented Feb 12, 2019

Hi @maddumarala, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: Ui Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants