New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed issue #20157 On advanced search page Price field misaligned on mobile view #21114

Merged
merged 4 commits into from Feb 13, 2019

Conversation

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 11, 2019

Original Pull Request

#20159

Description (*)

Fixed issue #20157 On advanced search page Price field misaligned on mobile view

Fixed Issues (if relevant)

  1. magento/magento2 #20157: On advanced search page Price field misaligned on mobile view

Manual testing scenarios (*)

  1. click on footer link "advanced search" check for price field mobile view.
  2. Check Price Field ,it is not properly aligned

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4209 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team moved this from TODO to Testing In Progress in Community Pull Requests Feb 11, 2019

@magento-engcom-team magento-engcom-team moved this from Testing In Progress to Merging In Progress in Community Pull Requests Feb 13, 2019

@magento-engcom-team magento-engcom-team merged commit 09c0f01 into magento:2.2-develop Feb 13, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Feb 13, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Community Pull Requests automation moved this from Merging In Progress to Done Feb 13, 2019

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2019

@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment