New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed Checkbox radio shadow 20859 #21117

Closed
wants to merge 2 commits into
base: 2.2-develop
from

Conversation

Projects
None yet
4 participants
@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 11, 2019

Original Pull Request

#20861

Description (*)

Fixed Issues (if relevant)

  1. #20859 Luma theme - Input Box and Radio Button shadow is not proper

Manual testing scenarios (*)

  1. Magento luma theme frontend in all the form
  2. You can find checkbox, Radio input box shaddow
  3. Reproduce pages : create account page, cart page and chekout page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch

This comment has been minimized.

Copy link
Contributor

dmytro-ch commented Feb 11, 2019

I guess these changes violate accessibility standards by complicating the navigation through a keyboard interface.

@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Feb 12, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment