New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied PHP-CS-Fixer: concat_space, no_multiline_whitespace_around_double_arrow, ordered_imports #21121

Open
wants to merge 1 commit into
base: 2.3-develop
from

Conversation

@yogeshsuhagiya
Copy link
Member

yogeshsuhagiya commented Feb 11, 2019

Description (*)

Applied following fixer rules:

  • PHP CS Fixer: concat_space
  • PHP CS Fixer: no_multiline_whitespace_around_double_arrow
  • PHP CS Fixer: ordered_imports

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @yogeshsuhagiya. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 15, 2019

Hi @miguelbalparda, thank you for the review.
ENGCOM-4276 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team moved this from TODO to Testing In Progress in Community Pull Requests Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment