New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 21126 : Import design break issue resolved #21128

Open
wants to merge 2 commits into
base: 2.3-develop
from

Conversation

@speedy008
Copy link
Contributor

speedy008 commented Feb 11, 2019

Description (*)

Backend Import behavior design break

Fixed Issues (if relevant)

1.#21126: Import design break issue resolved

Manual testing scenarios (*)

1.Login to backend > system > import
2.select any > Entity Type and without selecting any option click on check data

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@torhoehn

This comment has been minimized.

Copy link
Contributor

torhoehn commented Feb 13, 2019

@magento-engcom-team give me test instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 13, 2019

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 13, 2019

Hi @torhoehn, here is your new Magento instance.
Admin access: https://pr-21128.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@torhoehn
Copy link
Contributor

torhoehn left a comment

Checked manually in Backend.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 13, 2019

Hi @torhoehn, thank you for the review.
ENGCOM-4255 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team moved this from TODO to Testing In Progress in Community Pull Requests Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment